Paths

Table of Contentst

Differential D11448

[native] update `decrypt` method use `EncryptedData`
ClosedPublic
Actions

Authored by kamil on Mar 28 2024, 10:27 AM.

Tags

None

Referenced Files

	F3380397: D11448.diff
	Wed, Nov 27, 11:22 PM

	Unknown Object (File)
	Sun, Nov 24, 9:58 AM

	Unknown Object (File)
	Sun, Nov 24, 9:26 AM

	Unknown Object (File)
	Sun, Nov 24, 8:55 AM

	Unknown Object (File)
	Wed, Nov 13, 12:51 PM

	Unknown Object (File)
	Wed, Nov 13, 12:51 PM

	Unknown Object (File)
	Wed, Nov 13, 12:51 PM

	Unknown Object (File)
	Wed, Nov 13, 12:48 PM

View All 70 Files

Subscribers

Details

Reviewers

michal
marcin

Commits

rCOMMe82bd482bca4: [native] update `decrypt` method use `EncryptedData`

Summary

Context in ENG-7228.

Note: We use a shared olmAPI interface on both platforms, to split this logically into diffs sometimes I had to make changes on one platform and make some temporary changes on another platform to make sure CI passes but this approach is consistent and uses the same approach for both web and native.

Depends on D11447

Test Plan

Tested in D11451.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 28 2024, 10:27 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:27 AM

kamil added a child revision: D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.Mar 28 2024, 10:28 AM

Harbormaster completed remote builds in B27786: Diff 38476.Mar 28 2024, 10:42 AM

kamil edited the test plan for this revision. (Show Details)Mar 29 2024, 5:38 AM

kamil published this revision for review.Mar 29 2024, 5:43 AM

kamil edited the summary of this revision. (Show Details)

michal accepted this revision.Apr 2 2024, 2:30 AM

michal added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1255	Can we remove this constant now?

This revision is now accepted and ready to land.Apr 2 2024, 2:30 AM

remove const

Harbormaster completed remote builds in B27910: Diff 38654.Apr 2 2024, 3:37 AM

Closed by commit rCOMMe82bd482bca4: [native] update `decrypt` method use `EncryptedData` (authored by kamil). · Explain WhyApr 2 2024, 4:50 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMe82bd482bca4: [native] update `decrypt` method use `EncryptedData`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

6 lines

CommCoreModule.cpp

11 lines

_generated/

commJSI-generated.cpp

crypto/

8 lines

schema/

CommCoreModuleSchema.js

3 lines

Diff 38476

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/crypto/olm-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...