Differential D11451

[native] update `olm` session creation code use `EncryptedData`
ClosedPublic
Actions

Authored by kamil on Mar 28 2024, 10:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 12, 4:07 AM

	Unknown Object (File)
	Thu, Apr 11, 9:37 PM

	Unknown Object (File)
	Wed, Apr 10, 9:40 AM

	Unknown Object (File)
	Tue, Apr 9, 4:17 PM

	Unknown Object (File)
	Tue, Apr 9, 1:20 PM

	Unknown Object (File)
	Fri, Apr 5, 1:33 PM

	Unknown Object (File)
	Wed, Apr 3, 9:13 PM

	Unknown Object (File)
	Wed, Apr 3, 1:15 AM

View All 14 Files

Subscribers

Details

Reviewers

michal
marcin

Commits

rCOMM934defb418ba: [native] update `olm` session creation code use `EncryptedData`

Summary

Context in ENG-7228.

Depends on D11450

Test Plan

This is the last diff in the stack - where I tested everything end-to-end:

Logged to Identity on clients A and B
Create an outbound session on client A with client B.
Send a couple of messages from A to B.
Verify that messages are decrypted on B before B sends anything to A.
Send a couple of encrypted messages from B to A just in case and make sure it's decrypted correctly.

Tested multiple combinations, (native <> native, native <> web, web <> native).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 28 2024, 10:30 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:30 AM

Harbormaster completed remote builds in B27789: Diff 38479.Mar 28 2024, 10:51 AM

kamil edited the test plan for this revision. (Show Details)Mar 29 2024, 5:37 AM

kamil mentioned this in D11445: [web] update `encrypt` method to return `EncryptedData`.

kamil mentioned this in D11446: [native] update `encrypt` method to return `EncryptedData`.

kamil mentioned this in D11447: [web] update `decrypt` method use `EncryptedData`.

kamil mentioned this in D11448: [native] update `decrypt` method use `EncryptedData`.

kamil mentioned this in D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.

kamil mentioned this in D11450: [web] update `olm` session creation code use `EncryptedData`.

kamil published this revision for review.Mar 29 2024, 5:46 AM

marcin accepted this revision.Tue, Apr 2, 2:57 AM

This revision is now accepted and ready to land.Tue, Apr 2, 2:57 AM

rebase before landing

Harbormaster completed remote builds in B27911: Diff 38655.Tue, Apr 2, 3:39 AM

Closed by commit rCOMM934defb418ba: [native] update `olm` session creation code use `EncryptedData` (authored by kamil). · Explain WhyTue, Apr 2, 4:50 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM4d7b6ae221a1: [web] update `encrypt` method to return `EncryptedData`.

kamil mentioned this in rCOMM8e305bc4b8fd: [native] update `encrypt` method to return `EncryptedData`.

kamil mentioned this in rCOMM6fb9738f9734: [web] update `decrypt` method use `EncryptedData`.

kamil mentioned this in rCOMMe82bd482bca4: [native] update `decrypt` method use `EncryptedData`.

kamil mentioned this in rCOMM8b91ec580024: [web] update `olm` session creation code use `EncryptedData`.

kamil mentioned this in rCOMMcf2726c82cb3: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.

kamil added a commit: rCOMM934defb418ba: [native] update `olm` session creation code use `EncryptedData`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

33 lines

_generated/

commJSI-generated.cpp

crypto/

9 lines

schema/

CommCoreModuleSchema.js

9 lines

Diff 38662

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/crypto/olm-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...