Page MenuHomePhabricator
Differential D11496

[lib] Fix keyserver sending updated RoleInfos to old clients
ClosedPublic
Actions

Authored by ashoat on Mar 31 2024, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 8:38 AM
Unknown Object (File)
Mon, Dec 16, 8:38 AM
Unknown Object (File)
Mon, Dec 16, 8:37 AM
Unknown Object (File)
Mon, Dec 16, 7:43 AM
Unknown Object (File)
Fri, Dec 6, 7:41 PM
Unknown Object (File)
Nov 24 2024, 12:47 PM
Unknown Object (File)
Nov 24 2024, 12:20 PM
Unknown Object (File)
Nov 24 2024, 10:58 AM
View All 52 Files
Subscribers
atul
tomek

Details

Reviewers
atul
Commits
rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients
Summary

@atul's recent changes caused a major issue where new RoleInfos were being delivered to older clients, causing validation failures.

This diff makes it so keyserver can continue outputting the old-style RoleInfos to current clients.

Test Plan

I deployed this to prod and:

  1. Confirmed web app refreshed without issue
  2. Confirmed web app could log out / back in
  3. Confirmed native could receive a message without seeing validation errors
  4. Confirmed native could press a notif without seeing validation errors
  5. Confirmed native could log out / back in

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fixprod
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 31 2024, 7:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 31 2024, 7:14 PM
ashoat published this revision for review.Mar 31 2024, 7:15 PM
Harbormaster completed remote builds in B27876: Diff 38609.Mar 31 2024, 7:30 PM
atul accepted this revision.Apr 1 2024, 12:43 PM

Thanks for catching and resolving this.

I definitely thought through this scenario, specifically when I introduced https://phab.comm.dev/D11286... shouldn't have missed it.

This revision is now accepted and ready to land.Apr 1 2024, 12:43 PM
Closed by commit rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients (authored by ashoat). · Explain WhyApr 1 2024, 5:55 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients.

Revision Contents
Changeset List

Diff 38609

View Options

lib/permissions/minimally-encoded-raw-thread-info-validators.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...