Paths

Table of Contentst

[native_rust_library] Extract utils module
ClosedPublic
Actions

Authored by bartek on Apr 1 2024, 11:46 PM.

Details

Reviewers

varun
michal

Commits

rCOMMd1b8579ff9e8: [native_rust_library] Extract utils module

Summary

Part of ENG-6713.

Created a submodule for utilities and moved them from lib.rs

Test Plan

The same test plan for the whole stack: each commit compiles on both platforms. At the final commit - played a bit with these APIs, made sure they're callable from JS

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 1 2024, 11:46 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 1 2024, 11:46 PM

bartek added a child revision: D11517: [native_rust_library] Create identity submodule.Apr 1 2024, 11:48 PM

Harbormaster completed remote builds in B27901: Diff 38645.Apr 2 2024, 12:05 AM

bartek published this revision for review.Apr 2 2024, 10:52 PM

varun accepted this revision.Apr 3 2024, 10:21 AM

This revision is now accepted and ready to land.Apr 3 2024, 10:21 AM

Closed by commit rCOMMd1b8579ff9e8: [native_rust_library] Extract utils module (authored by bartek). · Explain WhyApr 4 2024, 3:12 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd1b8579ff9e8: [native_rust_library] Extract utils module.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

4 lines

63 lines

2 lines

	utils/

future_manager.rs

77 lines

utils/

jsi_callbacks.rs

35 lines

Diff 38645

View Options

native/native_rust_library/src/backup.rs

View Options

native/native_rust_library/src/future_manager.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/native_rust_library/src/utils.rs

View Options

native/native_rust_library/src/utils/future_manager.rs

View Options

native/native_rust_library/src/utils/jsi_callbacks.rs

[native_rust_library] Extract utils moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38645

native/native_rust_library/src/backup.rs

native/native_rust_library/src/future_manager.rs

native/native_rust_library/src/lib.rs

native/native_rust_library/src/utils.rs

native/native_rust_library/src/utils/future_manager.rs

native/native_rust_library/src/utils/jsi_callbacks.rs

[native_rust_library] Extract utils module
ClosedPublic
Actions

Revision Contents
Changeset List