[native_rust_library] Cleanup remaining APIs
ClosedPublic
Actions

Authored by bartek on Mon, Apr 1, 11:54 PM.

Details

Reviewers

varun
michal

Commits

rCOMM0b089eaf031e: [native_rust_library] Cleanup remaining APIs

Summary

Final part of ENG-6713.

Moved remaining APIs to submodules
Fixed some clippy warnings

Depends on D11523

Test Plan

The same test plan for the whole stack: each commit compiles on both platforms. At the final commit (this commit) - played a bit with these APIs, made sure they're callable from JS

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Apr 1, 11:54 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Apr 1, 11:54 PM

Harbormaster completed remote builds in B27909: Diff 38653.Tue, Apr 2, 12:27 AM

bartek published this revision for review.Tue, Apr 2, 10:54 PM

varun accepted this revision.Wed, Apr 3, 10:31 AM

This revision is now accepted and ready to land.Wed, Apr 3, 10:31 AM

in your testing were you able to see Rust logs in Xcode or your terminal? noticed we have #[instrument] for some functions in this library but i don't think we configure tracing anywhere...

Rebase before landing

In D11524#331968, @varun wrote:

in your testing were you able to see Rust logs in Xcode or your terminal? noticed we have #[instrument] for some functions in this library but i don't think we configure tracing anywhere...

No, we were investigating this issue with @michal and discovered that there's no tracing subscriber configured for native. I've created a follow-up task to address this

Harbormaster completed remote builds in B27965: Diff 38751.Thu, Apr 4, 2:55 AM

Closed by commit rCOMM0b089eaf031e: [native_rust_library] Cleanup remaining APIs (authored by bartek). · Explain WhyThu, Apr 4, 3:12 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM0b089eaf031e: [native_rust_library] Cleanup remaining APIs.