[web] update `encrypt` method to return `EncryptedData`
ClosedPublic
Actions

Authored by kamil on Mar 28 2024, 10:19 AM.

Details

Reviewers

michal
marcin

Commits

rCOMM4d7b6ae221a1: [web] update `encrypt` method to return `EncryptedData`

Summary

Context in ENG-7228.

Note: We use a shared olmAPI interface on both platforms, to split this logically into diffs sometimes I had to make changes on one platform and make some temporary changes on another platform to make sure CI passes but this approach is consistent and uses the same approach for both web and native.

Test Plan

Tested in D11451.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 28 2024, 10:19 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:19 AM

kamil added a child revision: D11446: [native] update `encrypt` method to return `EncryptedData`.Mar 28 2024, 10:23 AM

Harbormaster completed remote builds in B27783: Diff 38473.Mar 28 2024, 10:34 AM

kamil edited the test plan for this revision. (Show Details)Mar 29 2024, 5:37 AM

kamil retitled this revision from [web] update web `encrypt` method to return `EncryptedData` to [web] update `encrypt` method to return `EncryptedData`.Mar 29 2024, 5:42 AM

kamil edited the summary of this revision. (Show Details)

kamil published this revision for review.Mar 29 2024, 5:44 AM

kamil added inline comments.

lib/types/crypto-types.js
117–120 ↗	(On Diff #38473)	matches native declaration: https://github.com/CommE2E/comm/blob/0390a90e673038762bfdbd3e3e300fe84c68a1a1/native/cpp/CommonCpp/CryptoTools/Tools.h#L26
native/crypto/olm-api.js
21–27 ↗	(On Diff #38473)	this is updated in next diff - added here to pass CI