Paths

Table of Contentst

Differential D11446

[native] update `encrypt` method to return `EncryptedData`
ClosedPublic
Actions

Authored by kamil on Mar 28 2024, 10:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 5:18 PM

	Unknown Object (File)
	Wed, Nov 13, 12:52 PM

	Unknown Object (File)
	Wed, Nov 13, 12:52 PM

	Unknown Object (File)
	Wed, Nov 13, 12:48 PM

	Unknown Object (File)
	Oct 11 2024, 9:36 AM

	Unknown Object (File)
	Oct 11 2024, 9:36 AM

	Unknown Object (File)
	Oct 11 2024, 9:36 AM

	Unknown Object (File)
	Oct 11 2024, 9:35 AM

View All 51 Files

Subscribers

Details

Reviewers

michal
marcin

Commits

rCOMM8e305bc4b8fd: [native] update `encrypt` method to return `EncryptedData`

Summary

Context in ENG-7228.

Note: We use a shared olmAPI interface on both platforms, to split this logically into diffs sometimes I had to make changes on one platform and make some temporary changes on another platform to make sure CI passes but this approach is consistent and uses the same approach for both web and native.

Depends on D11445

Test Plan

Tested in D11451.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 28 2024, 10:23 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:23 AM

kamil added a child revision: D11447: [web] update `decrypt` method use `EncryptedData`.Mar 28 2024, 10:26 AM

Harbormaster completed remote builds in B27784: Diff 38474.Mar 28 2024, 10:37 AM

kamil edited the test plan for this revision. (Show Details)Mar 29 2024, 5:38 AM

kamil edited the summary of this revision. (Show Details)Mar 29 2024, 5:43 AM

kamil published this revision for review.Mar 29 2024, 5:45 AM

michal accepted this revision.Apr 2 2024, 2:26 AM

This revision is now accepted and ready to land.Apr 2 2024, 2:26 AM

Closed by commit rCOMM8e305bc4b8fd: [native] update `encrypt` method to return `EncryptedData` (authored by kamil). · Explain WhyApr 2 2024, 4:50 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8e305bc4b8fd: [native] update `encrypt` method to return `EncryptedData`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

14 lines

crypto/

10 lines

schema/

CommCoreModuleSchema.js

5 lines

Diff 38657

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/crypto/olm-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...