[lib] Use identity service for keyserver session recovery
ClosedPublic
Actions

Authored by ashoat on Mar 31 2024, 7:43 PM.

Details

Reviewers

tomek
inka

Commits

Summary

This diff is gated on usingCommServicesAccessToken. We fall back to legacy keyserver auth if the new identity-based workflow doesn't work.

Depends on D11499

Test Plan

Tested in combination with later diffs:

Set up multi-keyserver environment following Notion doc
Test native keyserver recovery via keyserverAuth by deleting a cookie in MariaDB console
Hardcode incorrect userID, try same test as 2, and confirm that it fails
Test web keyserver recovery in the same way as in 2
Test incorrect userID on web in the same way as in 3

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

ashoat requested review of this revision.Mar 31 2024, 7:59 PM

tomek added inline comments.

lib/components/keyserver-connection-handler.js
169–170 ↗	(On Diff #38613)	Is there a reason to change the `awaiting` approach?

This revision is now accepted and ready to land.Apr 2 2024, 2:42 AM

lib/components/keyserver-connection-handler.js
169–170 ↗	(On Diff #38613)	To be honest, I'm not sure. I wrote this code months ago, but it took a while to test it and feel confident putting the diffs up. Looking at the `redux-thunk` docs, it seems like either approach should work. Before landing, I'll do some testing and see if we can keep the previous approach.