Page MenuHomePhabricator

[protos] Reorder some RPCs
ClosedPublic

Authored by bartek on Mar 28 2024, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 6:26 PM
Unknown Object (File)
Fri, Oct 18, 6:26 PM
Unknown Object (File)
Fri, Oct 18, 6:26 PM
Unknown Object (File)
Fri, Oct 18, 6:23 PM
Unknown Object (File)
Fri, Oct 11, 10:34 AM
Unknown Object (File)
Oct 1 2024, 2:34 AM
Unknown Object (File)
Sep 18 2024, 8:19 AM
Unknown Object (File)
Sep 11 2024, 11:43 PM
Subscribers

Details

Summary

Minor cleanup in proto file structure:

  • Replaced // ... with /* ... */ for group headers to emphasize them over other comments
  • Moved some RPCs between groups
  • This also reordered generated code

I'm open to other comment suggestions as well. I prioritized these because of RPC order affecting codegen

Depends on D11379

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Mar 28 2024, 11:05 PM

Seems reasonable

shared/protos/identity_unauth.proto
40–47 ↗(On Diff #38421)

Can we replace "Ashoat's" with "authoritative"?

This revision is now accepted and ready to land.Mar 29 2024, 10:47 AM

Use 'authoritative' where applicable

This revision was automatically updated to reflect the committed changes.