Paths

Table of Contentst

Differential D11548

[identity] Store social proof as a Map in DDB
ClosedPublic
Actions

Authored by bartek on Apr 4 2024, 4:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 4:32 AM

	Unknown Object (File)
	Sun, Dec 22, 4:32 AM

	Unknown Object (File)
	Sun, Dec 22, 4:32 AM

	Unknown Object (File)
	Sun, Dec 22, 4:32 AM

	Unknown Object (File)
	Sun, Dec 22, 4:32 AM

	Unknown Object (File)
	Sun, Dec 22, 4:32 AM

	Unknown Object (File)
	Nov 18 2024, 5:36 AM

	Unknown Object (File)
	Nov 18 2024, 3:46 AM

View All 63 Files

Subscribers

Details

Reviewers

varun
will

Commits

rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB

Summary

Instead of JSON-serializing and deserializing social proof, we can store it directly as a map attribute in DDB.

NOTE: Note this is breaking change - previous users with String social proof in DDB will fail. I found only 3 wallet users on staging and none on prod. I prefer manually migrating (or deleting) these 3 rows instead of keeping this code backwards compatible

Depends on D11547

Test Plan

Added unit test
Registered a wallet user and called FindUserIdentity to make sure that social proof is retrieved

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 4 2024, 4:24 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 4 2024, 4:24 AM

Harbormaster failed remote builds in B27967: Diff 38762!Apr 4 2024, 4:46 AM

Rebase

bartek edited the summary of this revision. (Show Details)Apr 4 2024, 4:51 AM

Harbormaster failed remote builds in B27969: Diff 38765!Apr 4 2024, 4:54 AM

bartek mentioned this in D11547: [protos] Refactor user Identity message type.Apr 4 2024, 5:06 AM

Harbormaster completed remote builds in B27969: Diff 38765.Apr 4 2024, 5:10 AM

bartek published this revision for review.Apr 4 2024, 5:11 AM

bartek added a child revision: D11549: [protos] Remove social_proof from IdentityKeyInfo.Apr 4 2024, 5:44 AM

varun accepted this revision.Apr 4 2024, 8:22 PM

varun added inline comments.

services/identity/src/siwe.rs
151	nit: maybe this should be named something else instead of `deserialized`, like `social_proof_from_attr`

This revision is now accepted and ready to land.Apr 4 2024, 8:22 PM

Rebase, Rename variable

Harbormaster completed remote builds in B28184: Diff 39073.Apr 12 2024, 3:46 AM

Closed by commit rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB (authored by bartek). · Explain WhyApr 15 2024, 1:44 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

8 lines

4 lines

6 lines

11 lines

grpc_services/

authenticated.rs

6 lines

34 lines

72 lines

Diff 38765

services/identity/src/client_service.rs

Loading...

services/identity/src/constants.rs

Loading...

services/identity/src/database.rs

Loading...

services/identity/src/ddb_utils.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...

services/identity/src/grpc_utils.rs

Loading...

services/identity/src/siwe.rs

Loading...