Page MenuHomePhabricator
Differential D11544

[web] Clear database on non-threadStore ops fail
ClosedPublic
Actions

Authored by michal on Apr 3 2024, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 6:54 PM
Unknown Object (File)
Sun, Nov 3, 1:59 AM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:18 PM
Unknown Object (File)
Oct 11 2024, 12:17 PM
Unknown Object (File)
Oct 11 2024, 12:17 PM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMM9705de4522f9: [web] Clear database on non-threadStore ops fail
Summary

ENG-7587 : Should we clear the web DB when some operations fail?
Clean the db on other (non-draft, non-report) ops.

Depends on D11539

Test Plan

Add throw new Error() on message store rekey op. Try sending a message. App displayed an alert and reloaded.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Apr 3 2024, 7:29 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2024, 7:29 AM
michal added a child revision: D11545: [web/native/lib] Use message pruner on web.Apr 3 2024, 7:40 AM
Harbormaster completed remote builds in B27954: Diff 38734.Apr 3 2024, 7:44 AM
michal requested review of this revision.Apr 3 2024, 7:44 AM
michal added a child revision: D11563: [web] Fix user not getting logged out on ops failure.Apr 5 2024, 2:59 AM
michal updated this revision to Diff 38842.Apr 5 2024, 3:02 AM

Rebase

Harbormaster completed remote builds in B28015: Diff 38842.Apr 5 2024, 3:24 AM
kamil accepted this revision.Apr 5 2024, 3:40 AM
kamil added inline comments.
web/shared-worker/utils/store.js
209–216 ↗(On Diff #38842)

can this be simplified using entries()? I am mostly worried about cases when someone adds something to storeOperations but forgets add it here so I will also inverse the condition

This revision is now accepted and ready to land.Apr 5 2024, 3:40 AM
michal updated this revision to Diff 38856.Apr 5 2024, 5:45 AM

Use entries instead of specifying each ops separately.

Harbormaster completed remote builds in B28027: Diff 38856.Apr 5 2024, 6:00 AM
Closed by commit rCOMM9705de4522f9: [web] Clear database on non-threadStore ops fail (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyApr 5 2024, 9:45 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM9705de4522f9: [web] Clear database on non-threadStore ops fail.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
utils/
10 lines

Diff 38856

View Options

web/shared-worker/utils/store.js

Loading...