[native] Add auxUserStore to persist blacklist
ClosedPublic
Actions

Authored by will on Apr 5 2024, 2:24 PM.

Details

Reviewers

ginsu
ashoat
kamil

Commits

rCOMM5ba637982dd6: [native] Add auxUserStore to persist blacklist

Summary

As we are only storing auxUserStore in sqlite, we should add auxUserStore to the persist blacklist

Context: https://linear.app/comm/issue/ENG-7656/add-auxuserstore-to-blacklist-to-avoid-possible-missing-rehydration

Test Plan

flow check

Diff Detail

Repository

rCOMM Comm

Branch

blacklist_aux_user_store

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Apr 5 2024, 2:24 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 5 2024, 2:24 PM

Harbormaster completed remote builds in B28030: Diff 38874.Apr 5 2024, 2:41 PM

will requested review of this revision.Apr 5 2024, 2:41 PM

Is this diff blocking native release? Is there a task tracking the rehydration warning?

seems reasonable, but want to make sure @kamil can also review this

will retitled this revision from [native] Add auxUserStore to persist blacklist to avoid rehydration warning to [native] Add auxUserStore to persist blacklist.Apr 5 2024, 3:17 PM

In D11566#332723, @ashoat wrote:

Is this diff blocking native release? Is there a task tracking the rehydration warning?

Actually haven't encountered a rehydration warning just yet so I should change the title of the diff. Unconfirmed with Kamil if this is needed but I'm assuming we do as we store auxUserStore in just sqlite.

I don't think there's any harm in landing this right now even if it's not needed.

Here's a similar situation with syncedMetadata: https://phab.comm.dev/D11422?id=38405#inline-69045

I'm not sure what triggered it last time in testing. But the fact that I'm not sure means this should block mobile release. Here's a linear issue I just made:

https://linear.app/comm/issue/ENG-7656/add-auxuserstore-to-blacklist-to-avoid-possible-missing-rehydration

will edited the summary of this revision. (Show Details)Apr 5 2024, 3:33 PM

will edited reviewers, added: ashoat; removed: kamil.

will added a reviewer: kamil.

Let's definitely land it! I'll hold off on initiating a release until it's landed

ashoat accepted this revision.Apr 5 2024, 3:39 PM

This revision is now accepted and ready to land.Apr 5 2024, 3:39 PM

Closed by commit rCOMM5ba637982dd6: [native] Add auxUserStore to persist blacklist (authored by will). · Explain WhyApr 5 2024, 4:02 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM5ba637982dd6: [native] Add auxUserStore to persist blacklist.