Introduces the synced metadata reducer which handles replace, remove, and remove all ops.
Depends on D11421
Details
Details
Ran the following code:
const onPressSave = React.useCallback(async () => {
dispatch({
type: addSyncedMetadataEntryActionType,
payload: {
name: 'Test_1_name',
data: 'Test_1_data',
},
});
dispatch({
type: addSyncedMetadataEntryActionType,
payload: {
name: 'Test_2_name',
data: 'Test_2_data',
},
});
dispatch({
type: addSyncedMetadataEntryActionType,
payload: {
name: 'Test_1_name',
data: 'Test_1_update',
},
});
dispatch({
type: removeSyncedMetadataEntryActionType,
payload: {
name: 'Test_2_name',
},
});
}, [dispatch]);
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
LGTM - requesting changes to address this blacklist comment because this is important
| lib/reducers/synced-metadata-reducer.js | ||
|---|---|---|
| 14 ↗ | (On Diff #38405) | |
| 30–33 ↗ | (On Diff #38405) | |
| lib/types/redux-types.js | ||
| 165 ↗ | (On Diff #38405) | This will be persisted only on SQL database so you should add this to persistBlacklist. Because there is no migration (and no need to do it) you should've seen alerts with EXPECTED KEYS NOT REHYDRATED. Separately - this started to be annoying, we have blacklist on native and whitelist on the web and it's easy to oversight this - could you create a follow-up task to address it anytime in the future? |
| lib/types/redux-types.js | ||
|---|---|---|
| 165 ↗ | (On Diff #38405) | Included as part of blacklist in latest rebase. Created the follow-up task on linear: https://linear.app/comm/issue/ENG-7602/rethink-redux-persist-blacklist-and-native-whitelist Left a question on what I should put as the parent |