Page MenuHomePhabricator
Differential D11421

[lib] introduce sync metadata add and remove action types
ClosedPublic
Actions

Authored by will on Mar 27 2024, 4:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:09 PM
Unknown Object (File)
Wed, Apr 10, 10:01 AM
Unknown Object (File)
Sun, Apr 7, 8:21 AM
Unknown Object (File)
Sat, Apr 6, 9:11 PM
Unknown Object (File)
Fri, Apr 5, 12:47 AM
Unknown Object (File)
Wed, Apr 3, 1:32 AM
Unknown Object (File)
Wed, Apr 3, 1:32 AM
Unknown Object (File)
Tue, Apr 2, 9:57 PM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
ginsu
kamil
atul
Commits
rCOMMebc836f84cf9: [lib] introduce sync metadata add and remove action types
Summary

This introduces the add and remove synced metadata entry action types

Depends on D11420

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mar 27 2024, 4:14 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 4:14 PM
will edited the summary of this revision. (Show Details)Mar 27 2024, 4:15 PM
will added a parent revision: D11420: [sqlite] implement processing synced metadata store ops on worker.
Harbormaster completed remote builds in B27739: Diff 38402.Mar 27 2024, 4:29 PM
will requested review of this revision.Mar 27 2024, 4:29 PM
will added a child revision: D11422: [lib/native/web] introduce synced metadata reducer.Mar 27 2024, 5:15 PM
kamil accepted this revision.Mar 28 2024, 4:55 AM
kamil added inline comments.
lib/types/redux-types.js
114 ↗(On Diff #38402)
lib/types/synced-metadata-types.js
9–16 ↗(On Diff #38402)
This revision is now accepted and ready to land.Mar 28 2024, 4:55 AM
will updated this revision to Diff 38472.Mar 28 2024, 10:13 AM

review feedback

Harbormaster completed remote builds in B27782: Diff 38472.Mar 28 2024, 10:31 AM
will marked 2 inline comments as done.Thu, Mar 28, 4:32 PM
Closed by commit rCOMMebc836f84cf9: [lib] introduce sync metadata add and remove action types (authored by will). · Explain WhyTue, Apr 2, 11:22 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMebc836f84cf9: [lib] introduce sync metadata add and remove action types.

Revision Contents
Changeset List

PathSize
lib/
actions/
10 lines
types/
12 lines
9 lines

Diff 38695

View Options

lib/actions/synced-metadata-actions.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/synced-metadata-types.js

Loading...