This implements the C++ SQLite operations for the synced metadata store
Depends on D11416
Details
Details
synced metadata queries test
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 146 ↗ | (On Diff #38396) | how about adding to makefile on Android? |
| web/shared-worker/queries/synced-metadata-queries.test.js | ||
| 11–12 ↗ | (On Diff #38396) | I think you can add more specific types or you don;t have to use ? operator below when calling methods |
| 63–65 ↗ | (On Diff #38396) | looks like the test name is not correct with what the test is doing |
| web/shared-worker/types/sqlite-query-executor.js | ||
| 129 ↗ | (On Diff #38396) | match param names here with native code for clarity |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 146 ↗ | (On Diff #38396) | I think I understand what's going on. A similar issue was mentioned in https://phab.comm.dev/D11300?vs=37980&id=38151#toc, where I didn't include IntegrityThreadHash.h in project.pbxproj. I just removed SyncedMetadataEntry.h from project.pbxproj and everything still seems to compile. This explains why CommunityInfo.h wasn't included in project.pbxproj in its diff stack. I think I can remove all references to SyncedMetadataEntry.h in project.pbxproj and create a follow-up task to remove IntegrityThreadHash.h as well. I believe this means we don't need to include them in the android Makefile |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
|---|---|---|
| 146 ↗ | (On Diff #38396) | Linear issue for removing IntegrityThreadHash.h: https://linear.app/comm/issue/ENG-7601/remove-integritythreadhashh-from-native-projectpbxproj |