Handle key permanently invalidated error to fix Android app crash
ClosedPublic
Actions

Authored by marcin on Apr 14 2024, 4:05 AM.

Details

Reviewers

ashoat
tomek
bartek

Commits

rCOMMde6a3fd1d383: Handle key permanently invalidated error to fix Android app crash

Summary

This differential fixes https://linear.app/comm/issue/ENG-7696/commsecurestore-crash-during-commmmkvinitialize. It is achieved by patching expo-secure-store according
to changes that expo team introduced in later version of this package:
https://github.com/expo/expo/pull/22716/commits/b94904a241711586a127e357283cca3192860efd#diff-779492a2d4624bb5a02d84e6ece255cde8f7178fc075eb1cc18b01e21eb8dc1a

Test Plan

Reproduce the crash by uninstalling and redeploying Android app from Android studio. It seems that the best device to reproduce in Pixel device or emulator running Android
Introduce this diff and see that the crash disappears.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-7696

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 14 2024, 4:05 AM

Harbormaster completed remote builds in B28210: Diff 39100.Apr 14 2024, 4:21 AM

marcin requested review of this revision.Apr 14 2024, 4:21 AM

ashoat accepted this revision.Apr 14 2024, 10:54 AM

This revision is now accepted and ready to land.Apr 14 2024, 10:54 AM

bartek accepted this revision.Apr 15 2024, 1:41 AM

Rebase before landing.

Harbormaster failed remote builds in B28214: Diff 39109!Apr 15 2024, 3:39 AM

Harbormaster completed remote builds in B28214: Diff 39109.Apr 15 2024, 4:00 AM

Closed by commit rCOMMde6a3fd1d383: Handle key permanently invalidated error to fix Android app crash (authored by marcin). · Explain WhyApr 15 2024, 4:11 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMde6a3fd1d383: Handle key permanently invalidated error to fix Android app crash.

Note that testing here was flawed and this definitely did not address ENG-7696. That said, I don't think it was a bad idea to land this.

Revision Contents
Changeset List

Path

Size

patches/

expo-secure-store+12.0.0.patch

98 lines

Diff 39109

View Options

patches/expo-secure-store+12.0.0.patch

Handle key permanently invalidated error to fix Android app crashClosedPublicActions