create new aux user store action for clearing fids
ClosedPublic
Actions

Authored by will on Apr 16 2024, 3:20 PM.

Details

Reviewers

atul
ginsu
ashoat

Commits

rCOMM2b05aaf6d911: create new aux user store action for clearing fids

Summary

This new action types clears any aux user store users of fids by setting them all to null.

Depends on D11671

Test Plan

Dispatched this action successfully and confirmed all aux user store entries contained null fid values (they were strings before).

Diff Detail

Repository

rCOMM Comm

Branch

sqlite/farcaster-friends

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Apr 16 2024, 3:20 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 16 2024, 3:20 PM

will edited the summary of this revision. (Show Details)Apr 16 2024, 3:20 PM

will added a parent revision: D11671: Makes fid optionally null so that we can delete the fid later.

will added a child revision: D11639: [lib] Add farcaster friend fids to sqlite.Apr 16 2024, 3:25 PM

I just added clearFarcasterFriendsFIDActionType for the case of a new fid, but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

Harbormaster completed remote builds in B28253: Diff 39164.Apr 16 2024, 3:36 PM

will requested review of this revision.Apr 16 2024, 3:36 PM

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

PS there are no reviewers on this diff

In D11672#335437, @ashoat wrote:

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

Got it. That answers my question. Was under the false impression this would only be for when we've connected our farcaster accounts.

Based on that, are any changes necessary here, or is this still ready to review?

In D11672#335437, @ashoat wrote:

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

In D11672#335459, @ashoat wrote:

Based on that, are any changes necessary here, or is this still ready to review?

This is all ready for review

Cool. It looks good to me, but I'd like somebody else to take a look at it as well

Looks good

Super minor nit, but we might want to settle on "farcaster friend" or "farcaster mutual" language? Doesn't really matter just a thought because we use farcaster_mutual for update_relationship

This revision is now accepted and ready to land.Apr 17 2024, 9:37 AM

Removing the language of friends. This action type will encompass wiping all aux user store data irregardless of whether or not the user is friends with them or not.

Context: https://phab.comm.dev/D11639

Will land once I rename

rename clear to not include friends

Harbormaster completed remote builds in B28317: Diff 39265.Apr 18 2024, 8:48 PM

Closed by commit rCOMM2b05aaf6d911: create new aux user store action for clearing fids (authored by will). · Explain WhyApr 18 2024, 9:13 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM2b05aaf6d911: create new aux user store action for clearing fids.