Page MenuHomePhabricator
Differential D11807

[native] Fix pending state in ExistingEthereumAccount for identity auth
ClosedPublic
Actions

Authored by ashoat on Apr 26 2024, 11:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 1:14 PM
Unknown Object (File)
Tue, Nov 12, 1:07 PM
Unknown Object (File)
Tue, Nov 12, 10:54 AM
Unknown Object (File)
Tue, Nov 12, 8:29 AM
Unknown Object (File)
Oct 11 2024, 7:13 AM
Unknown Object (File)
Oct 11 2024, 7:13 AM
Unknown Object (File)
Oct 11 2024, 7:13 AM
Unknown Object (File)
Oct 11 2024, 7:13 AM
View All 41 Files
Subscribers
tomek

Details

Reviewers
inka
Commits
rCOMM0fdc58b6d2ec: [native] Fix pending state in ExistingEthereumAccount for identity auth
Summary

Noticed while working on the stack ending in D11806 that the pending state here is only handled for the legacy auth.

Changed it here and did some corresponding reworking of the logic.

Depends on D11806

Test Plan

Careful reading of the code

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 26 2024, 11:30 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 26 2024, 11:30 AM
ashoat removed a parent revision: D11806: [lib][native][web] Rename LogInExtraInfo to LegacyLogInExtraInfo.Apr 26 2024, 11:32 AM
Harbormaster completed remote builds in B28525: Diff 39570.Apr 26 2024, 11:57 AM
ashoat requested review of this revision.Apr 26 2024, 11:57 AM
inka accepted this revision.Apr 30 2024, 8:51 AM
inka added inline comments.
native/account/registration/existing-ethereum-account.react.js
39–41 ↗(On Diff #39570)

The RegistrationButton button is disabled when variant === 'disabled' || variant === 'loading', so this is not needed, but I suppose it's safer

This revision is now accepted and ready to land.Apr 30 2024, 8:51 AM
Closed by commit rCOMM0fdc58b6d2ec: [native] Fix pending state in ExistingEthereumAccount for identity auth (authored by ashoat). · Explain WhyApr 30 2024, 9:34 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM0fdc58b6d2ec: [native] Fix pending state in ExistingEthereumAccount for identity auth.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
69 lines

Diff 39706

View Options

native/account/registration/existing-ethereum-account.react.js

Loading...