Paths

Table of Contentst

Differential D11908

[native_rust_library] reserved registration client methods for wallet and password users
ClosedPublic
Actions

Authored by varun on May 6 2024, 7:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 23, 4:01 PM

	Unknown Object (File)
	Mon, Dec 23, 4:01 PM

	Unknown Object (File)
	Mon, Dec 23, 4:00 PM

	Unknown Object (File)
	Mon, Dec 23, 4:00 PM

	Unknown Object (File)
	Nov 25 2024, 10:42 AM

	Unknown Object (File)
	Nov 12 2024, 12:08 AM

	Unknown Object (File)
	Nov 11 2024, 11:42 PM

	Unknown Object (File)
	Nov 11 2024, 11:34 PM

View All 58 Files

Subscribers

Details

Reviewers

bartek
will

Commits

rCOMMcc67d00576f0: [native_rust_library] reserved registration client methods for wallet and…

Summary

we need these client methods to call the reserved registration RPCs if login fails because the user exists on ashoat's keyserver but is not yet registered on identity

Test Plan

tested from js later in stack by calling the useLogIn hook with a reserved username and reserved wallet address and confirming that i was registered on identity

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.May 6 2024, 7:22 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 6 2024, 7:22 AM

varun added a child revision: D11909: [native] add registerReservedWalletUser and registerReservedPasswordUser to CommRustModule.May 6 2024, 7:24 AM

varun edited the test plan for this revision. (Show Details)May 6 2024, 7:33 AM

Harbormaster completed remote builds in B28704: Diff 39852.May 6 2024, 7:38 AM

varun requested review of this revision.May 6 2024, 7:38 AM

bartek accepted this revision.May 7 2024, 1:59 AM

This revision is now accepted and ready to land.May 7 2024, 1:59 AM

When rebasing, you'll have to add initial_device_list to Reserved*RegistrationRequest - see D12017 and the following diffs in that stack

Closed by commit rCOMMcc67d00576f0: [native_rust_library] reserved registration client methods for wallet and… (authored by varun). · Explain WhyMay 20 2024, 7:05 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMcc67d00576f0: [native_rust_library] reserved registration client methods for wallet and….

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

36 lines

identity/

44 lines

registration.rs

209 lines

34 lines

Diff 39852

native/native_rust_library/src/identity.rs

Loading...

native/native_rust_library/src/identity/login.rs

Loading...

native/native_rust_library/src/identity/registration.rs

Loading...

native/native_rust_library/src/lib.rs

Loading...