Updated the QR Auth flow on primary device to sign the device list update with Olm account before calling the UpdateDeviceList RPC.
Depends on D11899
Details
Details
- Reviewers
kamil - Commits
- rCOMMd666dc9bfd54: [native] Sign device list during QR auth
Performed the QR Auth flow. Then called the GetDeviceListHistoryForUser RPC to check if the signature is present for the latest update.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/qr-code/qr-code-utils.js | ||
|---|---|---|
| 73 ↗ | (On Diff #39838) | Should we somehow call olmAPI instead? Not sure how we're supposed to do it now |
| native/qr-code/qr-code-utils.js | ||
|---|---|---|
| 67 ↗ | (On Diff #39838) | worth adding utils function like isPrimary - I guess we'll use it a lot in future |
| 73 ↗ | (On Diff #39838) | olmAPI was introduced to use code from /lib - here it doesn't make such a difference as this is only native code but I think it is worth using the olmAPI interface everywhere instead of the direct commCoreModule call |