This exposes FindUserIdentities to C++ through native rust library
Depends on D11952
Details
Details
Tested rpc calls on client later in stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/native_rust_library/src/identity/find_user_identities.rs | ||
|---|---|---|
| 34–53 ↗ | (On Diff #40090) | Was wondering if we should move this somewhere else in native_rust_library. Unsure if we'll need this for any future rpcs |
| 54–55 ↗ | (On Diff #40090) | Implemented this and the above structs as our protobuf generated Rust code lacks the Serialize trait. |
| native/native_rust_library/src/identity/find_user_identities.rs | ||
|---|---|---|
| 34–53 ↗ | (On Diff #40090) | Perhaps you could move it to src/identity.rs but it can stay here as well. |
| 54–55 ↗ | (On Diff #40090) | Alternatively, you could use type alias to avoid wrapping the hashmap in a struct type UserIdentities = HashMap<String, Identity>; // then this impl TryFrom<UserIdentitiesResponse> for UserIdentities { ... } // becomes the same as impl TryFrom<UserIdentitiesResponse> for HashMap<String, Identity> { ... } |
| native/native_rust_library/src/identity/find_user_identities.rs | ||
|---|---|---|
| 52 ↗ | (On Diff #40090) | We should add it to address @ashoat's comment in https://phab.comm.dev/D12000#inline-71167 |