Page MenuHomePhabricator
Differential D12144

[native] Refactor MediaGalleryMedia to function component
ClosedPublic
Actions

Authored by inka on May 21 2024, 6:51 AM.
Tags
None
Referenced Files
F3390031: D12144.diff
Fri, Nov 29, 9:43 PM
Unknown Object (File)
Sun, Nov 10, 4:22 AM
Unknown Object (File)
Sat, Nov 9, 9:10 PM
Unknown Object (File)
Sat, Nov 9, 8:39 PM
Unknown Object (File)
Sat, Nov 9, 8:39 PM
Unknown Object (File)
Sat, Nov 9, 2:19 PM
Unknown Object (File)
Fri, Nov 8, 11:08 AM
Unknown Object (File)
Sep 26 2024, 1:44 AM
View All 54 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM25659221f5ee: [native] Refactor MediaGalleryMedia to function component
Summary

I need this component to be a function to be able to use useAnimatedStyle when migrating to Reanimated 2

Test Plan

Teset that the gallery still works - its possible to send, queue, dequeue media. The animations seem to work as previously

Diff Detail

Repository
rCOMM Comm
Branch
inka/reanimated
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.May 21 2024, 6:51 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 21 2024, 6:51 AM
inka added a comment.May 21 2024, 6:54 AM

Not sure about memoizing buttons, media and overlay...

Harbormaster completed remote builds in B29098: Diff 40462.May 21 2024, 7:11 AM
inka requested review of this revision.May 21 2024, 7:11 AM
ashoat accepted this revision.May 21 2024, 10:03 AM

Looks great!

native/media/media-gallery-media.react.js
57–65 ↗(On Diff #40462)

I think it would improve readability to use the same order that is defined in Props

232 ↗(On Diff #40462)

Now that we have a function component, it's easier to memoize things. Can we memoize [mediaStyle, dimensionsStyle], to avoid passing a new style to AnimatedImage on every render?

This revision is now accepted and ready to land.May 21 2024, 10:03 AM
inka updated this revision to Diff 40495.May 21 2024, 11:10 AM

Address review

inka added a child revision: D12160: [native] Convert MediaGalleryMedia to Reanimated 2 syntax.May 21 2024, 11:18 AM
Harbormaster completed remote builds in B29127: Diff 40495.May 21 2024, 11:27 AM
Closed by commit rCOMM25659221f5ee: [native] Refactor MediaGalleryMedia to function component (authored by inka). · Explain WhyMay 24 2024, 9:18 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM25659221f5ee: [native] Refactor MediaGalleryMedia to function component.

Revision Contents
Changeset List

PathSize
native/
media/
318 lines

Diff 40495

View Options

native/media/media-gallery-media.react.js

Loading...