Paths

Table of Contentst

[native] Fix MediaGalleryKeyboard on Android
ClosedPublic
Actions

Authored by ashoat on May 21 2024, 2:43 PM.

Tags

None

Referenced Files

	F3552306: D12167.id40519.diff
	Thu, Dec 26, 7:41 PM

	F3552135: D12167.id40518.diff
	Thu, Dec 26, 7:35 PM

	Unknown Object (File)
	Thu, Dec 26, 5:06 AM

	Unknown Object (File)
	Nov 9 2024, 11:08 PM

	Unknown Object (File)
	Nov 9 2024, 10:33 PM

	Unknown Object (File)
	Nov 9 2024, 12:41 PM

	Unknown Object (File)
	Nov 8 2024, 4:29 PM

	Unknown Object (File)
	Nov 7 2024, 8:02 AM

View All 44 Files

Subscribers

tomek

Details

Reviewers

ginsu
bartek

Commits

rCOMM001c4d8f0e12: [native] Fix MediaGalleryKeyboard on Android

Summary

This addresses ENG-8159. See the inline comment for more details.

Test Plan

Confirm that we can see media in the MediaGalleryKeyboard on my physical Android device

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 21 2024, 2:43 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 21 2024, 2:43 PM

Harbormaster completed remote builds in B29149: Diff 40518.May 21 2024, 3:01 PM

ashoat requested review of this revision.May 21 2024, 3:01 PM

bartek accepted this revision.May 21 2024, 10:44 PM

This revision is now accepted and ready to land.May 21 2024, 10:44 PM

Closed by commit rCOMM001c4d8f0e12: [native] Fix MediaGalleryKeyboard on Android (authored by ashoat). · Explain WhyMay 22 2024, 2:10 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM001c4d8f0e12: [native] Fix MediaGalleryKeyboard on Android.

Revision Contents
Changeset List

Path

Size

native/

keyboard/

keyboard-state-container.react.js

10 lines

media/

media-gallery-keyboard.react.js

9 lines

Diff 40518

View Options

native/keyboard/keyboard-state-container.react.js