HomePhabricator
Diffusion Comm 16bd7386a16c

[native] Avoid calling our custom Alert from reducers

Description

[native] Avoid calling our custom Alert from reducers

Summary:
The test plan in D12124 points out an issue where our custom Alert is called from a reducer, but I didn't catch all of these cases.

The code in onStateDifference is called from reducers as well, so we should use the stock React Native Alert here as well.

Test Plan: I have a repro of this locally, and I was able to confirm that the error no longer occurs when the Alert is triggered

Reviewers: ginsu, marcin

Reviewed By: ginsu, marcin

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D12159

Details

Provenance
ashoatAuthored on May 21 2024, 10:11 AM
Reviewer
ginsu
Differential Revision
D12159: [native] Avoid calling our custom Alert from reducers
Parents
rCOMM2e351aa5e747: [native] Convert TabBar to Reanimated 2 syntax
Branches
Unknown
Tags
Unknown