Paths

Table of Contentst

Differential D12124

[native] Avoid importing Alert directly from react-native
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:44 AM.

Details

Reviewers

ginsu

Commits

rCOMM2d844e8a2ea4: [native] Avoid importing Alert directly from react-native

Summary

Our custom Alert in native/utils/alert.js just wraps the default one with a userInterfaceStyle call based on the current user theme.

Depends on D12123

Test Plan

I made sure the app runs with these. I had to remove the usage of our custom Alert from redux-setup.js because it led to this error:

2024-05-20 15.31.00.png (2×1 px, 287 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 20 2024, 6:44 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 6:44 AM

ashoat added a child revision: D12125: [web] Show VersionUnsupportedModal if QR code auth fails due to unsupported client version.May 20 2024, 6:45 AM

ashoat edited the test plan for this revision. (Show Details)May 20 2024, 6:56 AM

Harbormaster completed remote builds in B29063: Diff 40404.May 20 2024, 7:00 AM

ashoat requested review of this revision.May 20 2024, 7:00 AM

ginsu accepted this revision.May 20 2024, 7:19 AM

This revision is now accepted and ready to land.May 20 2024, 7:19 AM

Closed by commit rCOMM2d844e8a2ea4: [native] Avoid importing Alert directly from react-native (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2d844e8a2ea4: [native] Avoid importing Alert directly from react-native.

ashoat mentioned this in D12159: [native] Avoid calling our custom Alert from reducers.May 21 2024, 10:13 AM

ashoat mentioned this in rCOMM16bd7386a16c: [native] Avoid calling our custom Alert from reducers.May 21 2024, 1:30 PM

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

connect-farcaster.react.js

2 lines

missing-registration-data/

missing-siwe-backup-message.react.js

2 lines

registration-terms.react.js

3 lines

siwe-backup-message-creation.react.js

3 lines

profile/

backup-menu.react.js

3 lines

farcaster-account-settings.react.js

3 lines

redux/

redux-debug-utils.js

2 lines

utils/

farcaster-utils.js

2 lines

Diff 40441

View Options

native/account/registration/connect-farcaster.react.js

View Options

native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js

View Options

native/account/registration/registration-terms.react.js

View Options

native/account/registration/siwe-backup-message-creation.react.js

View Options

native/profile/backup-menu.react.js

View Options

native/profile/farcaster-account-settings.react.js

View Options

native/redux/redux-debug-utils.js

View Options

native/utils/farcaster-utils.js

[native] Avoid importing Alert directly from react-nativeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40441

native/account/registration/connect-farcaster.react.js

native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js

native/account/registration/registration-terms.react.js

native/account/registration/siwe-backup-message-creation.react.js

native/profile/backup-menu.react.js

native/profile/farcaster-account-settings.react.js

native/redux/redux-debug-utils.js

native/utils/farcaster-utils.js

[native] Avoid importing Alert directly from react-native
ClosedPublic
Actions

Revision Contents
Changeset List