Page MenuHomePhabricator
Differential D12124

[native] Avoid importing Alert directly from react-native
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 4:19 PM
Unknown Object (File)
Fri, Mar 28, 10:10 AM
Unknown Object (File)
Wed, Mar 26, 9:03 AM
Unknown Object (File)
Fri, Mar 21, 4:56 PM
Unknown Object (File)
Feb 27 2025, 11:10 PM
Unknown Object (File)
Feb 26 2025, 8:02 AM
Unknown Object (File)
Feb 26 2025, 8:02 AM
Unknown Object (File)
Feb 26 2025, 12:02 AM
View All 69 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMM2d844e8a2ea4: [native] Avoid importing Alert directly from react-native
Summary

Our custom Alert in native/utils/alert.js just wraps the default one with a userInterfaceStyle call based on the current user theme.

Depends on D12123

Test Plan

I made sure the app runs with these. I had to remove the usage of our custom Alert from redux-setup.js because it led to this error:

2024-05-20 15.31.00.png (2×1 px, 287 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 40441

View Options

native/account/registration/connect-farcaster.react.js

Show All 13 Linesimport {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js'; import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
GlobalAccountUserInfo, GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines void (async () => {
setUsernameToSearch(lowercaseText); setUsernameToSearch(lowercaseText);
} }
})(); })();
}, [ensCache, lowercaseText]); }, [ensCache, lowercaseText]);
return usernameToSearch; return usernameToSearch;
} }
function useSearchIdentityUsers(
usernameInputText: string,
): $ReadOnlyArray<User> {
const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const { sendPrefixQuery } = useIdentitySearch();
const [searchResults, setSearchResults] = React.useState(
ashoatUnsubmitted
Not Done
Inline Actions

Same comment here... please move the typehint

ashoat: Same comment here... please move the typehint
ashoatUnsubmitted
Not Done
Inline Actions

Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here.

In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid.

Okay to skip it this time I guess

ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
willAuthorUnsubmitted
Done
Inline Actions

Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward.

will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
([]: $ReadOnlyArray<User>),
);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
React.useEffect(() => {
if (forwardLookupSearchText.length === 0) {
setSearchResults([]);
return;
}
void (async () => {
try {
const result = await sendPrefixQuery(forwardLookupSearchText);
setSearchResults(
result.filter(({ userID }) => userID !== currentUserID),
);
} catch (err) {
console.error(err);
setSearchResults([]);
}
})();
}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);
return searchResults;
}
function useSearchUsers( function useSearchUsers(
usernameInputText: string, usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> { ): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector( const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText); const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems; return sortedChatMessageInfoItems;
} }
export { export {
usePotentialMemberItems, usePotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
useSearchIdentityUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
useForwardLookupSearchText, useForwardLookupSearchText,
}; };
View Options

native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js

Show All 13 Linesimport {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js'; import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
GlobalAccountUserInfo, GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines void (async () => {
setUsernameToSearch(lowercaseText); setUsernameToSearch(lowercaseText);
} }
})(); })();
}, [ensCache, lowercaseText]); }, [ensCache, lowercaseText]);
return usernameToSearch; return usernameToSearch;
} }
function useSearchIdentityUsers(
usernameInputText: string,
): $ReadOnlyArray<User> {
const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const { sendPrefixQuery } = useIdentitySearch();
const [searchResults, setSearchResults] = React.useState(
ashoatUnsubmitted
Not Done
Inline Actions

Same comment here... please move the typehint

ashoat: Same comment here... please move the typehint
ashoatUnsubmitted
Not Done
Inline Actions

Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here.

In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid.

Okay to skip it this time I guess

ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
willAuthorUnsubmitted
Done
Inline Actions

Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward.

will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
([]: $ReadOnlyArray<User>),
);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
React.useEffect(() => {
if (forwardLookupSearchText.length === 0) {
setSearchResults([]);
return;
}
void (async () => {
try {
const result = await sendPrefixQuery(forwardLookupSearchText);
setSearchResults(
result.filter(({ userID }) => userID !== currentUserID),
);
} catch (err) {
console.error(err);
setSearchResults([]);
}
})();
}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);
return searchResults;
}
function useSearchUsers( function useSearchUsers(
usernameInputText: string, usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> { ): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector( const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText); const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems; return sortedChatMessageInfoItems;
} }
export { export {
usePotentialMemberItems, usePotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
useSearchIdentityUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
useForwardLookupSearchText, useForwardLookupSearchText,
}; };
View Options

native/account/registration/registration-terms.react.js

Show All 13 Linesimport {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js'; import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
GlobalAccountUserInfo, GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines void (async () => {
setUsernameToSearch(lowercaseText); setUsernameToSearch(lowercaseText);
} }
})(); })();
}, [ensCache, lowercaseText]); }, [ensCache, lowercaseText]);
return usernameToSearch; return usernameToSearch;
} }
function useSearchIdentityUsers(
usernameInputText: string,
): $ReadOnlyArray<User> {
const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const { sendPrefixQuery } = useIdentitySearch();
const [searchResults, setSearchResults] = React.useState(
ashoatUnsubmitted
Not Done
Inline Actions

Same comment here... please move the typehint

ashoat: Same comment here... please move the typehint
ashoatUnsubmitted
Not Done
Inline Actions

Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here.

In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid.

Okay to skip it this time I guess

ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
willAuthorUnsubmitted
Done
Inline Actions

Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward.

will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
([]: $ReadOnlyArray<User>),
);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
React.useEffect(() => {
if (forwardLookupSearchText.length === 0) {
setSearchResults([]);
return;
}
void (async () => {
try {
const result = await sendPrefixQuery(forwardLookupSearchText);
setSearchResults(
result.filter(({ userID }) => userID !== currentUserID),
);
} catch (err) {
console.error(err);
setSearchResults([]);
}
})();
}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);
return searchResults;
}
function useSearchUsers( function useSearchUsers(
usernameInputText: string, usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> { ): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector( const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText); const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems; return sortedChatMessageInfoItems;
} }
export { export {
usePotentialMemberItems, usePotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
useSearchIdentityUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
useForwardLookupSearchText, useForwardLookupSearchText,
}; };
View Options

native/account/registration/siwe-backup-message-creation.react.js

Show All 13 Linesimport {
useSearchMessages as useSearchMessagesAction, useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js'; } from '../actions/message-actions.js';
import { import {
searchUsers, searchUsers,
searchUsersActionTypes, searchUsersActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js'; import genesis from '../facts/genesis.js';
import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type { import type {
ChatMessageInfoItem, ChatMessageInfoItem,
MessageListData, MessageListData,
} from '../selectors/chat-selectors.js'; } from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js'; import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js'; import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js'; import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type { import type {
AccountUserInfo, AccountUserInfo,
GlobalAccountUserInfo, GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines void (async () => {
setUsernameToSearch(lowercaseText); setUsernameToSearch(lowercaseText);
} }
})(); })();
}, [ensCache, lowercaseText]); }, [ensCache, lowercaseText]);
return usernameToSearch; return usernameToSearch;
} }
function useSearchIdentityUsers(
usernameInputText: string,
): $ReadOnlyArray<User> {
const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,
);
const { sendPrefixQuery } = useIdentitySearch();
const [searchResults, setSearchResults] = React.useState(
ashoatUnsubmitted
Not Done
Inline Actions

Same comment here... please move the typehint

ashoat: Same comment here... please move the typehint
ashoatUnsubmitted
Not Done
Inline Actions

Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here.

In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid.

Okay to skip it this time I guess

ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
willAuthorUnsubmitted
Done
Inline Actions

Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward.

will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
([]: $ReadOnlyArray<User>),
);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
React.useEffect(() => {
if (forwardLookupSearchText.length === 0) {
setSearchResults([]);
return;
}
void (async () => {
try {
const result = await sendPrefixQuery(forwardLookupSearchText);
setSearchResults(
result.filter(({ userID }) => userID !== currentUserID),
);
} catch (err) {
console.error(err);
setSearchResults([]);
}
})();
}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);
return searchResults;
}
function useSearchUsers( function useSearchUsers(
usernameInputText: string, usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> { ): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector( const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText); const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems; return sortedChatMessageInfoItems;
} }
export { export {
usePotentialMemberItems, usePotentialMemberItems,
notFriendNotice, notFriendNotice,
useSearchMessages, useSearchMessages,
useSearchUsers, useSearchUsers,
useSearchIdentityUsers,
filterChatMessageInfosForSearch, filterChatMessageInfosForSearch,
useForwardLookupSearchText, useForwardLookupSearchText,
}; };
View Options

native/profile/backup-menu.react.js

Loading...
View Options

native/profile/farcaster-account-settings.react.js

Loading...
View Options

native/redux/redux-debug-utils.js

Loading...
View Options

native/utils/farcaster-utils.js

Loading...