Page MenuHomePhabricator
Differential D12124

[native] Avoid importing Alert directly from react-native
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 20, 4:57 PM
Unknown Object (File)
Thu, Jun 20, 4:57 PM
Unknown Object (File)
Thu, Jun 20, 4:57 PM
Unknown Object (File)
Thu, Jun 20, 4:55 PM
Unknown Object (File)
Fri, Jun 14, 6:36 PM
Unknown Object (File)
Tue, Jun 11, 4:48 PM
Unknown Object (File)
Mon, Jun 10, 12:28 AM
Unknown Object (File)
Sun, Jun 9, 11:58 PM
View All 21 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMM2d844e8a2ea4: [native] Avoid importing Alert directly from react-native
Summary

Our custom Alert in native/utils/alert.js just wraps the default one with a userInterfaceStyle call based on the current user theme.

Depends on D12123

Test Plan

I made sure the app runs with these. I had to remove the usage of our custom Alert from redux-setup.js because it led to this error:

2024-05-20 15.31.00.png (2×1 px, 287 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 40441

View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js

Loading...
View Options

native/account/registration/registration-terms.react.js

Loading...
View Options

native/account/registration/siwe-backup-message-creation.react.js

Loading...
View Options

native/profile/backup-menu.react.js

Loading...
View Options

native/profile/farcaster-account-settings.react.js

Loading...
View Options

native/redux/redux-debug-utils.js

Loading...
View Options

native/utils/farcaster-utils.js

Loading...