[lib] Refactor useLogIn to be more generic
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 3:58 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM55c6bdebe0c6: [lib] Refactor useLogIn to be more generic

Summary

useLogIn is a helper function internal to login-hooks.js. This diff refactors the helper function in preparation for a new use case that will be introduced in the next diff.

Right now useLogIn is coupled with the specific forms of login that it supports; this diff makes it more generic.

Depends on D12112

Test Plan

I tested the flow using staging, with my phone as a primary device and a local simulator as a secondary device

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 20 2024, 3:58 AM

ashoat added a child revision: D12114: [lib][native][web] Introduce useSecondaryDeviceLogIn.

Harbormaster completed remote builds in B29050: Diff 40387.May 20 2024, 4:27 AM

ashoat requested review of this revision.May 20 2024, 4:27 AM

ashoat edited the summary of this revision. (Show Details)May 20 2024, 10:58 PM

bartek accepted this revision.May 21 2024, 12:44 AM

bartek added inline comments.

lib/hooks/login-hooks.js
35 ↗	(On Diff #40387)	Nit: maybe name this argument to hint at what kind of promise this is
156 ↗	(On Diff #40387)	nit

This revision is now accepted and ready to land.May 21 2024, 12:44 AM

Review

This revision was landed with ongoing or failed builds.May 21 2024, 1:11 AM

Closed by commit rCOMM55c6bdebe0c6: [lib] Refactor useLogIn to be more generic (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM55c6bdebe0c6: [lib] Refactor useLogIn to be more generic.

Harbormaster completed remote builds in B29079: Diff 40428.May 21 2024, 1:14 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

85 lines

Diff 40436

View Options

[lib] Refactor useLogIn to be more genericClosedPublicActions