Paths

Table of Contentst

Differential D12125

[web] Show VersionUnsupportedModal if QR code auth fails due to unsupported client version
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 1:04 PM

	Unknown Object (File)
	Sat, Nov 9, 12:59 PM

	Unknown Object (File)
	Sat, Nov 9, 12:57 PM

	Unknown Object (File)
	Sat, Nov 9, 5:27 AM

	Unknown Object (File)
	Fri, Nov 8, 9:33 PM

	Unknown Object (File)
	Sat, Nov 2, 1:49 AM

	Unknown Object (File)
	Sat, Nov 2, 1:48 AM

	Unknown Object (File)
	Sat, Nov 2, 1:37 AM

View All 48 Files

Subscribers

Details

Reviewers

Commits

rCOMMfd8369f0b265: [web] Show VersionUnsupportedModal if QR code auth fails due to unsupported…

Summary

I originally noticed that the QR code flow didn't handle this error when investigating ENG-8113. That led to the further realization that the QR code flow hasn't been kept up-to-date, which was addressed in ENG-8123. This diff completes the circle and finally adds code to handle the outdated client error specifically.

Depends on D12124

Test Plan

I hardcoded a failure in keyserver/src/session/version.js for all web clients and saw this error:

Screenshot 2024-05-20 at 3.34.16 PM.png (930×1 px, 80 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 20 2024, 6:45 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 6:45 AM

ashoat added a child revision: D12126: [web] Show generic Alert if an error occurs during QR code auth.May 20 2024, 6:46 AM

ashoat edited the test plan for this revision. (Show Details)May 20 2024, 6:56 AM

Harbormaster completed remote builds in B29064: Diff 40405.May 20 2024, 7:01 AM

ashoat requested review of this revision.May 20 2024, 7:01 AM

bartek accepted this revision.May 20 2024, 10:21 PM

This revision is now accepted and ready to land.May 20 2024, 10:21 PM

Closed by commit rCOMMfd8369f0b265: [web] Show VersionUnsupportedModal if QR code auth fails due to unsupported… (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfd8369f0b265: [web] Show VersionUnsupportedModal if QR code auth fails due to unsupported….

Revision Contents
Changeset List

Path

Size

web/

account/

qr-code-login.react.js

14 lines

components/

log-out-if-missing-csat-handler.react.js

2 lines

missing-csat-modal.css

6 lines

version-handler.css

version-handler.react.js

14 lines

modals/

version-unsupported-modal.css

6 lines

version-unsupported-modal.react.js

21 lines

Diff 40442

web/account/qr-code-login.react.js

Loading...

web/components/log-out-if-missing-csat-handler.react.js

Loading...

web/components/missing-csat-modal.css

Loading...

web/components/version-handler.css

Loading...

web/components/version-handler.react.js

Loading...

web/modals/version-unsupported-modal.css

Loading...

web/modals/version-unsupported-modal.react.js

Loading...