Page MenuHomePhabricator
Differential D12126

[web] Show generic Alert if an error occurs during QR code auth
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 28, 2:17 AM
Unknown Object (File)
Thu, Jun 20, 4:57 PM
Unknown Object (File)
Thu, Jun 20, 4:57 PM
Unknown Object (File)
Thu, Jun 20, 4:57 PM
Unknown Object (File)
Thu, Jun 20, 4:55 PM
Unknown Object (File)
Sun, Jun 16, 8:17 PM
Unknown Object (File)
Sun, Jun 16, 5:40 PM
Unknown Object (File)
Sun, Jun 16, 5:21 PM
View All 30 Files
Subscribers
tomek

Details

Reviewers
bartek
Commits
rCOMM1691c4483d57: [web] Show generic Alert if an error occurs during QR code auth
Summary

This matches behavior on native. It's better to show something than to silently fail.

Depends on D12125

Test Plan

I hardcoded a failure in the web implementation of IdentityServiceClient and saw this error:

Screenshot 2024-05-20 at 3.39.17 PM.png (1×1 px, 104 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
account/
3 lines

Diff 40443

View Options

web/account/qr-code-login.react.js

Loading...