Page MenuHomePhabricator

[web] Show generic Alert if an error occurs during QR code auth
ClosedPublic

Authored by ashoat on May 20 2024, 6:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 1:37 AM
Unknown Object (File)
Fri, Nov 1, 6:43 PM
Unknown Object (File)
Thu, Oct 31, 6:57 PM
Unknown Object (File)
Tue, Oct 29, 12:46 AM
Unknown Object (File)
Fri, Oct 25, 5:19 AM
Unknown Object (File)
Thu, Oct 24, 8:08 PM
Unknown Object (File)
Thu, Oct 24, 4:41 AM
Unknown Object (File)
Wed, Oct 23, 9:25 PM
Subscribers

Details

Summary

This matches behavior on native. It's better to show something than to silently fail.

Depends on D12125

Test Plan

I hardcoded a failure in the web implementation of IdentityServiceClient and saw this error:

Screenshot 2024-05-20 at 3.39.17 PM.png (1×1 px, 104 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable