This matches behavior on native. It's better to show something than to silently fail.
Depends on D12125
Differential D12126 Authored by ashoat on May 20 2024, 6:46 AM.
Details Summary This matches behavior on native. It's better to show something than to silently fail. Depends on D12125 Test Plan
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 6:46 AM2024-05-20 06:46:14 (UTC-7) ashoat edited the test plan for this revision. (Show Details)May 20 2024, 6:56 AM2024-05-20 06:56:58 (UTC-7) Harbormaster completed remote builds in B29065: Diff 40406.May 20 2024, 7:03 AM2024-05-20 07:03:32 (UTC-7) This revision is now accepted and ready to land.May 21 2024, 12:45 AM2024-05-21 00:45:14 (UTC-7) Closed by commit rCOMM1691c4483d57: [web] Show generic Alert if an error occurs during QR code auth (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM2024-05-21 01:11:30 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 40443 web/account/qr-code-login.react.js
|
Same comment here... please move the typehint