Page MenuHomePhabricator

[web] Show generic Alert if an error occurs during QR code auth
ClosedPublic

Authored by ashoat on May 20 2024, 6:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 6:57 PM
Unknown Object (File)
Sun, Nov 24, 2:45 PM
Unknown Object (File)
Sat, Nov 23, 6:36 PM
Unknown Object (File)
Thu, Nov 14, 12:41 PM
Unknown Object (File)
Sat, Nov 9, 1:00 PM
Unknown Object (File)
Sat, Nov 9, 12:59 PM
Unknown Object (File)
Sat, Nov 9, 12:57 PM
Unknown Object (File)
Sat, Nov 9, 5:27 AM
Subscribers

Details

Summary

This matches behavior on native. It's better to show something than to silently fail.

Depends on D12125

Test Plan

I hardcoded a failure in the web implementation of IdentityServiceClient and saw this error:

Screenshot 2024-05-20 at 3.39.17 PM.png (1×1 px, 104 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable