Page MenuHomePhabricator
Differential D12126

[web] Show generic Alert if an error occurs during QR code auth
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:46 AM.
Tags
None
Referenced Files
F3389820: D12126.diff
Fri, Nov 29, 8:41 PM
Unknown Object (File)
Sun, Nov 24, 6:57 PM
Unknown Object (File)
Sun, Nov 24, 2:45 PM
Unknown Object (File)
Sat, Nov 23, 6:36 PM
Unknown Object (File)
Thu, Nov 14, 12:41 PM
Unknown Object (File)
Sat, Nov 9, 1:00 PM
Unknown Object (File)
Sat, Nov 9, 12:59 PM
Unknown Object (File)
Sat, Nov 9, 12:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
bartek
Commits
rCOMM1691c4483d57: [web] Show generic Alert if an error occurs during QR code auth
Summary

This matches behavior on native. It's better to show something than to silently fail.

Depends on D12125

Test Plan

I hardcoded a failure in the web implementation of IdentityServiceClient and saw this error:

Screenshot 2024-05-20 at 3.39.17 PM.png (1×1 px, 104 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
account/
3 lines

Diff 40406

View Options

web/account/qr-code-login.react.js

Loading...