[native][web] Get rid of unnecessary React state for QR code URL
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 3:54 AM.

Details

Reviewers

Commits

rCOMM46643c3a9b5c: [native][web] Get rid of unnecessary React state for QR code URL

Summary

This can be derived from other state. We should avoid duplicating state to prevent the possibility of it becoming inconsistent.

Depends on D12107

Test Plan

I tested the flow using staging, with my phone as a primary device and a local simulator as a secondary device

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 20 2024, 3:54 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 3:54 AM

ashoat added a child revision: D12109: [native][web] Fetch AES key and device ID in parallel in generateQRCode.May 20 2024, 3:54 AM

Harbormaster completed remote builds in B29045: Diff 40382.May 20 2024, 4:09 AM

ashoat requested review of this revision.May 20 2024, 4:09 AM

bartek accepted this revision.May 20 2024, 5:27 AM

This revision is now accepted and ready to land.May 20 2024, 5:27 AM

Closed by commit rCOMM46643c3a9b5c: [native][web] Get rid of unnecessary React state for QR code URL (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM46643c3a9b5c: [native][web] Get rid of unnecessary React state for QR code URL.

Revision Contents
Changeset List

Path

Size

native/

qr-code/

qr-code-screen.react.js

10 lines

web/

account/

qr-code-login.react.js

14 lines

Diff 40432

View Options

native/qr-code/qr-code-screen.react.js