Page MenuHomePhabricator
Differential D12159

[native] Avoid calling our custom Alert from reducers
ClosedPublic
Actions

Authored by ashoat on May 21 2024, 10:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 5:28 AM
Unknown Object (File)
Fri, Jun 21, 5:28 AM
Unknown Object (File)
Fri, Jun 21, 5:28 AM
Unknown Object (File)
Fri, Jun 21, 5:27 AM
Unknown Object (File)
Thu, Jun 20, 11:17 PM
Unknown Object (File)
Thu, Jun 13, 1:37 AM
Unknown Object (File)
Mon, Jun 10, 4:03 AM
Unknown Object (File)
Sun, Jun 9, 9:51 PM
View All 20 Files
Subscribers
tomek

Details

Reviewers
ginsu
marcin
Commits
rCOMM16bd7386a16c: [native] Avoid calling our custom Alert from reducers
Summary

The test plan in D12124 points out an issue where our custom Alert is called from a reducer, but I didn't catch all of these cases.

The code in onStateDifference is called from reducers as well, so we should use the stock React Native Alert here as well.

Test Plan

I have a repro of this locally, and I was able to confirm that the error no longer occurs when the Alert is triggered

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
redux/
2 lines

Diff 40515

View Options

native/redux/redux-debug-utils.js

Loading...