[native] Avoid calling our custom Alert from reducers
ClosedPublic
Actions

Authored by ashoat on May 21 2024, 10:13 AM.

Details

Reviewers

ginsu
marcin

Commits

rCOMM16bd7386a16c: [native] Avoid calling our custom Alert from reducers

Summary

The test plan in D12124 points out an issue where our custom Alert is called from a reducer, but I didn't catch all of these cases.

The code in onStateDifference is called from reducers as well, so we should use the stock React Native Alert here as well.

Test Plan

I have a repro of this locally, and I was able to confirm that the error no longer occurs when the Alert is triggered

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 21 2024, 10:13 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 21 2024, 10:13 AM

Harbormaster completed remote builds in B29126: Diff 40494.May 21 2024, 10:30 AM

ashoat requested review of this revision.May 21 2024, 10:30 AM

ashoat added a reviewer: marcin.May 21 2024, 1:27 PM

ginsu accepted this revision.May 21 2024, 1:28 PM

This revision is now accepted and ready to land.May 21 2024, 1:28 PM

marcin accepted this revision.May 21 2024, 1:29 PM

Closed by commit rCOMM16bd7386a16c: [native] Avoid calling our custom Alert from reducers (authored by ashoat). · Explain WhyMay 21 2024, 1:30 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM16bd7386a16c: [native] Avoid calling our custom Alert from reducers.

Revision Contents
Changeset List

Path

Size

native/

redux/

redux-debug-utils.js

2 lines

Diff 40515

View Options

native/redux/redux-debug-utils.js

[native] Avoid calling our custom Alert from reducersClosedPublicActions