Details
- Reviewers
tomek ashoat kamil - Commits
- rCOMMbb773af95385: [lib] Fix invite links validation
Tested that invite links work correclty now
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/fixValidation
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
lib/utils/user-info-extraction-utils.js | ||
---|---|---|
53 | Every use of any and its equivalents should be explicitly justified. What else did you try here? Why is this absolutely necessary? |
lib/utils/user-info-extraction-utils.js | ||
---|---|---|
31 | * is basically any and has been deprecated in Flow for a long time. This should never have been introduced in 2024. Please replace it |
lib/utils/user-info-extraction-utils.js | ||
---|---|---|
55 ↗ | (On Diff #40578) | The any casts are now for the same reason as in D7488
Using the same approach as there |
61 ↗ | (On Diff #40578) | Fixing maybe type as well, because otherwise update_user_avatar fails |
lib/utils/user-info-extraction-utils.js | ||
---|---|---|
55 ↗ | (On Diff #40578) | I'm having trouble re-casting it. The correct type is TInterface<T>, but then I again get
In D7488 we had an input field which we would use to hack this problem. |
lib/utils/user-info-extraction-utils.js | ||
---|---|---|
55 ↗ | (On Diff #40580) | Object is basically any as well. Can you use eg. { ... }? |