Page MenuHomePhabricator
Differential D3526

[services] Tunnelbroker - Validate sessionID and deviceID in database entities.
ClosedPublic
Actions

Authored by • max on Mar 28 2022, 6:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 10:37 PM
Unknown Object (File)
Fri, Mar 14, 10:36 PM
Unknown Object (File)
Fri, Mar 14, 10:35 PM
Unknown Object (File)
Feb 6 2025, 11:30 AM
Unknown Object (File)
Feb 2 2025, 11:11 AM
Unknown Object (File)
Feb 1 2025, 4:28 PM
Unknown Object (File)
Feb 1 2025, 7:40 AM
Unknown Object (File)
Feb 1 2025, 7:40 AM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
• karol
varun
Commits
rCOMMfb186959aef0: [services] Tunnelbroker - Validate sessionID and deviceID in database entities.
Summary

Validating sessionID and deviceID fields in database item entities using validation functions in Tools.

Note:
Validating empty strings are moved to D3525 which will be merged.

Related linear task: ENG-618

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Mar 28 2022, 6:47 AM
Herald added subscribers: • benschac, • karol, atul and 3 others. · View Herald TranscriptMar 28 2022, 6:47 AM
• max edited the summary of this revision. (Show Details)Mar 28 2022, 6:50 AM
• max added reviewers: tomek, • karol, varun.
Harbormaster completed remote builds in B7646: Diff 10740.Mar 28 2022, 6:57 AM
• max requested review of this revision.Mar 28 2022, 6:57 AM
ashoat added a comment.EditedMar 28 2022, 10:45 AM

If this diff has a dependency on D3525, please specify it! You can do this by hitting "Edit Related Revisions..." in the UI on this page, or you can do it by specifying "Depends on Dsomething" in the diff description when creating the diff with arc diff.

(Apologies if there is no dependency, I may be misunderstanding your diff description.)

tomek requested changes to this revision.Mar 29 2022, 5:51 AM
tomek added inline comments.
services/tunnelbroker/src/Database/MessageItem.cpp
36–47 ↗(On Diff #10740)

Shouldn't we keep checking messageID and expire?

This revision now requires changes to proceed.Mar 29 2022, 5:51 AM
• max planned changes to this revision.Mar 30 2022, 4:24 AM
• max updated this revision to Diff 10877.Mar 31 2022, 6:06 AM

Moving it on top of D3525 to be more clear.

• max added a parent revision: D3525: [services] Tunnelbroker - Empty field checks in database items.Mar 31 2022, 6:07 AM
• max marked an inline comment as done.
• max added inline comments.
services/tunnelbroker/src/Database/MessageItem.cpp
36–47 ↗(On Diff #10740)

Shouldn't we keep checking messageID and expire?

Right, but it's on the other diff.
Moved it on top of the D3525 to be more clear.

Harbormaster completed remote builds in B7761: Diff 10877.Mar 31 2022, 6:13 AM
• max mentioned this in D3525: [services] Tunnelbroker - Empty field checks in database items.Mar 31 2022, 6:16 AM
• max marked an inline comment as done.Mar 31 2022, 6:20 AM
In D3526#96388, @ashoat wrote:

If this diff has a dependency on D3525, please specify it! You can do this by hitting "Edit Related Revisions..." in the UI on this page, or you can do it by specifying "Depends on Dsomething" in the diff description when creating the diff with arc diff.

(Apologies if there is no dependency, I may be misunderstanding your diff description.)

It was like two separate parallel diffs that will be merged. But I'm changing to Parent-Child diffs stack right now to be more clear.
Thanks!

tomek accepted this revision.Mar 31 2022, 8:43 AM
This revision is now accepted and ready to land.Mar 31 2022, 8:43 AM
• max updated this revision to Diff 11148.Apr 7 2022, 2:41 AM

Rebasing on master. Merging changes.

Harbormaster completed remote builds in B7954: Diff 11148.Apr 7 2022, 2:48 AM
• max updated this revision to Diff 11158.Apr 7 2022, 2:50 AM

Rebase on master.

This revision was landed with ongoing or failed builds.Apr 7 2022, 2:51 AM
Closed by commit rCOMMfb186959aef0: [services] Tunnelbroker - Validate sessionID and deviceID in database entities. (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMfb186959aef0: [services] Tunnelbroker - Validate sessionID and deviceID in database entities..
Harbormaster completed remote builds in B7955: Diff 11158.Apr 7 2022, 2:57 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Database/
6 lines
6 lines
3 lines
3 lines

Diff 11159

View Options

services/tunnelbroker/src/Database/DeviceSessionItem.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/Database/MessageItem.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/Database/PublicKeyItem.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/Database/SessionSignItem.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesconst light = Object.freeze({
subthreadsModalClose: designSystemColors.shadesBlack60, subthreadsModalClose: designSystemColors.shadesBlack60,
subthreadsModalBackground: designSystemColors.shadesWhite80, subthreadsModalBackground: designSystemColors.shadesWhite80,
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: designSystemColors.shadesBlack100, messageLabel: designSystemColors.shadesBlack100,
modalSeparator: designSystemColors.shadesWhite60, modalSeparator: designSystemColors.shadesWhite60,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesBlack100, inviteLinkLinkColor: designSystemColors.shadesBlack100,
inviteLinkButtonBackground: designSystemColors.shadesWhite60, inviteLinkButtonBackground: designSystemColors.shadesWhite60,
emojiKeyboardKnob: designSystemColors.shadesWhite90,
emojiKeyboardCategoryIcon: designSystemColors.shadesBlack70,
emojiKeyboardContainerActive: designSystemColors.shadesWhite90,
ashoatUnsubmitted
Not Done
Inline Actions

Do we really need one-offs here? Why can't we find an existing color family that works with our designs?

We need to push the team (@tedchang in particular) to use existing families (and update them as necessary) instead of hacking around inconsistencies like this. When we take this sort of approach of picking colors on a per-screen basis, we fail to maintain stylistic / design consistency throughout the app

ashoat: Do we really need one-offs here? Why can't we find an existing color family that works with our…
ashoatUnsubmitted
Not Done
Inline Actions

Meant to tag @ted

ashoat: Meant to tag @ted
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: designSystemColors.shadesBlack60, blockQuoteBorder: designSystemColors.shadesBlack60,
codeBackground: designSystemColors.shadesBlack100, codeBackground: designSystemColors.shadesBlack100,
disabledButton: designSystemColors.shadesBlack80, disabledButton: designSystemColors.shadesBlack80,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: designSystemColors.shadesBlack80, typeaheadTooltipBorder: designSystemColors.shadesBlack80,
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: designSystemColors.shadesWhite60, messageLabel: designSystemColors.shadesWhite60,
modalSeparator: designSystemColors.shadesBlack80, modalSeparator: designSystemColors.shadesBlack80,
secondaryButtonBorder: designSystemColors.shadesWhite100, secondaryButtonBorder: designSystemColors.shadesWhite100,
inviteLinkLinkColor: designSystemColors.shadesWhite80, inviteLinkLinkColor: designSystemColors.shadesWhite80,
inviteLinkButtonBackground: designSystemColors.shadesBlack80, inviteLinkButtonBackground: designSystemColors.shadesBlack80,
emojiKeyboardKnob: designSystemColors.shadesWhite100,
emojiKeyboardCategoryIcon: designSystemColors.shadesWhite70,
emojiKeyboardContainerActive: designSystemColors.shadesBlack60,
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines