Page MenuHomePhabricator
Differential D12204

[lib] update types to allow missing OTK when creating session
ClosedPublic
Actions

Authored by kamil on May 23 2024, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 9:09 PM
Unknown Object (File)
Wed, Mar 12, 6:15 AM
Unknown Object (File)
Tue, Mar 11, 2:56 PM
Unknown Object (File)
Wed, Mar 5, 10:00 PM
Unknown Object (File)
Feb 27 2025, 11:58 AM
Unknown Object (File)
Feb 21 2025, 7:23 AM
Unknown Object (File)
Feb 21 2025, 7:23 AM
Unknown Object (File)
Jan 24 2025, 6:38 AM
View All 84 Files
Subscribers
ashoat
marcin

Details

Reviewers
marcin
tomek
Commits
rCOMM9b33c8f7a408: [lib] update types to allow missing OTK when creating session
Summary

Modifying types and callsites to reflect new olm API.

Depends on D12203

Test Plan

Tested end-to-end:

  1. Tested content session with OTKs on both web and native
  2. Tested content session without OTKs on both web native
  3. Tested notifs
  4. Tested backward compatibility: @marcin was running his devices logged to staging on old olm version, and I was running the new version (this stack). WIth one OTKs it works as previously (tested both me and Marcin sending requests to each other and tested both platform). When there are no OTKs Marcin was unable to create a session request (same as now), I was able to create a session request, but it failed on Martin’s device with BAD_MESSAGE_KEY_ID but without crashing the app.

Diff Detail

Repository
rCOMM Comm
Branch
otks
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 23 2024, 4:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 23 2024, 4:23 AM
kamil mentioned this in D12202: [native] update `olm` API to allow creating session without OTKs.May 23 2024, 4:28 AM
kamil mentioned this in D12203: [web] update `olm` API to allow creating session without OTKs.
Harbormaster completed remote builds in B29206: Diff 40577.May 23 2024, 4:39 AM
kamil published this revision for review.May 23 2024, 5:50 AM
ashoat added a comment.May 24 2024, 3:44 AM

Exciting!!

kamil added a comment.May 24 2024, 8:28 AM

Note to myself to update the code after D12131 is landed

tomek accepted this revision.May 28 2024, 4:39 AM
This revision is now accepted and ready to land.May 28 2024, 4:39 AM
kamil updated this revision to Diff 40827.Jun 3 2024, 3:04 AM
  • update createOlmSessionWithPeer
  • rebase before landing
Harbormaster completed remote builds in B29347: Diff 40827.Jun 3 2024, 3:20 AM
Closed by commit rCOMM9b33c8f7a408: [lib] update types to allow missing OTK when creating session (authored by kamil). · Explain WhyJun 3 2024, 3:23 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM84ed5f6bbfd4: [native] update `olm` API to allow creating session without OTKs.
kamil mentioned this in rCOMM4fa54458b461: [web] update `olm` API to allow creating session without OTKs.
kamil added a commit: rCOMM9b33c8f7a408: [lib] update types to allow missing OTK when creating session.

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
utils/
8 lines
native/
identity-service/
18 lines
web/
grpc/
18 lines

Diff 40827

View Options

lib/types/request-types.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

lib/utils/crypto-utils.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

native/identity-service/identity-service-context-provider.react.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;
View Options

web/grpc/identity-service-client-wrapper.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import { import {
RelationshipListItemTooltipModalRouteName, RelationshipListItemTooltipModalRouteName,
FriendListRouteName, FriendListRouteName,
BlockListRouteName, BlockListRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js'; import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js'; import type { VerticalBounds } from '../types/layout-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
type BaseProps = { type BaseProps = {
+userInfo: AccountUserInfo, +userInfo: AccountUserInfo,
+lastListItem: boolean, +lastListItem: boolean,
+verticalBounds: ?VerticalBounds, +verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>, +relationshipListRoute: NavigationRoute<'FriendList' | 'BlockList'>,
+navigate: RelationshipListNavigate, +navigate: RelationshipListNavigate,
Show All 10 Linestype Props = {
// async functions that hit server APIs // async functions that hit server APIs
+updateRelationships: ( +updateRelationships: (
request: RelationshipRequest, request: RelationshipRequest,
) => Promise<RelationshipErrors>, ) => Promise<RelationshipErrors>,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
// withKeyboardState // withKeyboardState
+keyboardState: ?KeyboardState, +keyboardState: ?KeyboardState,
+navigateToUserProfileBottomSheet: (userID: string) => mixed,
}; };
class RelationshipListItem extends React.PureComponent<Props> { class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>(); editButton = React.createRef<React.ElementRef<typeof View>>();
render() { render() {
const { const {
lastListItem, lastListItem,
removeUserLoadingStatus, removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines ) {
> >
<Text style={this.props.styles.blueAction}>Add</Text> <Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
return ( return (
<View style={[this.props.styles.container, borderBottom]}> <View style={[this.props.styles.container, borderBottom]}>
<TouchableOpacity
ginsuAuthorUnsubmitted
Done
Inline Actions

The red background shows the TouchableOpacity:

Screenshot 2023-09-25 at 10.10.09 AM.png (1×1 px, 711 KB)

I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username

ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
atulUnsubmitted
Not Done
Inline Actions

What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon.

Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that

A. the element is interactive
B. the bounds of the tap target

Something like:

684a67.png (1×2 px, 418 KB)

or

1181e5.png (1×1 px, 309 KB)

atul: What surfaces should be "touchable" is probably something we should consider as part of the…
ashoatUnsubmitted
Not Done
Inline Actions

I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system

ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
tedUnsubmitted
Not Done
Inline Actions

In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge.

I think the touch point can extend more on the left, to where Search starts at the input field above.

@atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc.

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this.

With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you!

ted: > In this particular case, it feels a little weird that we're extending so far to the right…
ginsuAuthorUnsubmitted
Done
Inline Actions

For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering.

I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does.

To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container

ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
onPress={this.onPressUser}
style={this.props.styles.userInfoContainer}
>
<UserAvatar size="small" userID={this.props.userInfo.id} /> <UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}> <SingleLine style={this.props.styles.username}>
{this.props.userInfo.username} {this.props.userInfo.username}
</SingleLine> </SingleLine>
</TouchableOpacity>
{editButton} {editButton}
</View> </View>
); );
} }
onPressUser = () => {
this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
};
onSelect = () => { onSelect = () => {
const { id, username } = this.props.userInfo; const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username }); this.props.onSelect({ id, username });
}; };
visibleEntryIDs() { visibleEntryIDs() {
const { relationshipListRoute } = this.props; const { relationshipListRoute } = this.props;
const id = { const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines container: {
paddingHorizontal: 24, paddingHorizontal: 24,
paddingVertical: 10, paddingVertical: 10,
backgroundColor: 'panelForeground', backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder', borderColor: 'panelForegroundBorder',
}, },
borderBottom: { borderBottom: {
borderBottomWidth: 1, borderBottomWidth: 1,
}, },
userInfoContainer: {
flex: 1,
flexDirection: 'row',
},
buttonContainer: { buttonContainer: {
flexDirection: 'row', flexDirection: 'row',
}, },
editButtonWithMargin: { editButtonWithMargin: {
marginLeft: 15, marginLeft: 15,
}, },
username: { username: {
color: 'panelForegroundSecondaryLabel', color: 'panelForegroundSecondaryLabel',
Show All 29 Lines ) {
); );
const colors = useColors(); const colors = useColors();
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships); const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext); const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext); const keyboardState = React.useContext(KeyboardContext);
const navigateToUserProfileBottomSheet =
useNavigateToUserProfileBottomSheet();
return ( return (
<RelationshipListItem <RelationshipListItem
{...props} {...props}
removeUserLoadingStatus={removeUserLoadingStatus} removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors} colors={colors}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships} updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext} overlayContext={overlayContext}
keyboardState={keyboardState} keyboardState={keyboardState}
navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/> />
); );
}); });
export default ConnectedRelationshipListItem; export default ConnectedRelationshipListItem;