Page MenuHomePhabricator
Differential D12335

[identity] reintroduce check to make sure only wallet users can call deleteWalletUser RPC
ClosedPublic
Actions

Authored by varun on Jun 6 2024, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:56 PM
Unknown Object (File)
Wed, Nov 13, 1:43 PM
Unknown Object (File)
Wed, Nov 13, 1:43 PM
Unknown Object (File)
Wed, Nov 13, 12:49 PM
Unknown Object (File)
Tue, Nov 12, 4:46 PM
Unknown Object (File)
Tue, Nov 5, 10:50 PM
Unknown Object (File)
Oct 11 2024, 7:21 PM
Unknown Object (File)
Oct 11 2024, 7:21 PM
View All 58 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
will
Commits
rCOMMd08a0d0edfbb: [identity] reintroduce check to make sure only wallet users can call…
Summary

Depends on D12326

Devs will have to pull changes from D12326 to delete password accounts after this change is added to staging

Test Plan

i got a permission denied error trying to call deleteWalletUser from a password account

Diff Detail

Repository
rCOMM Comm
Branch
delete
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 6 2024, 1:20 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2024, 1:20 PM
varun updated this revision to Diff 41073.Jun 6 2024, 1:25 PM

also removing 2 lines from web that are not necessary

Harbormaster completed remote builds in B29499: Diff 41072.Jun 6 2024, 1:38 PM
Harbormaster completed remote builds in B29500: Diff 41073.Jun 6 2024, 1:41 PM
varun requested review of this revision.Jun 6 2024, 1:41 PM
will accepted this revision.Jun 6 2024, 3:58 PM
This revision is now accepted and ready to land.Jun 6 2024, 3:58 PM
varun added a child revision: D12353: [native][lib] update useDeleteDiscardedIdentityAccount to throw.Jun 7 2024, 9:11 AM
Closed by commit rCOMMd08a0d0edfbb: [identity] reintroduce check to make sure only wallet users can call… (authored by varun). · Explain WhyJun 7 2024, 11:47 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMd08a0d0edfbb: [identity] reintroduce check to make sure only wallet users can call….
varun mentioned this in D12515: [identity] fix wallet account deletion bug.Jun 20 2024, 11:13 AM
varun mentioned this in rCOMM30437f95dcbf: [identity] fix wallet account deletion bug.Jun 24 2024, 10:29 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
grpc_services/
10 lines
web/
grpc/
2 lines

Diff 41073

View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

web/grpc/identity-service-context-provider.react.js

Loading...