Page MenuHomePhabricator
Differential D12515

[identity] fix wallet account deletion bug
ClosedPublic
Actions

Authored by varun on Jun 20 2024, 11:13 AM.
Tags
None
Referenced Files
F3487286: D12515.id41651.diff
Wed, Dec 18, 7:30 AM
F3487284: D12515.id41572.diff
Wed, Dec 18, 7:30 AM
F3487268: D12515.id.diff
Wed, Dec 18, 7:30 AM
F3487255: D12515.diff
Wed, Dec 18, 7:30 AM
Unknown Object (File)
Nov 3 2024, 4:56 AM
Unknown Object (File)
Oct 25 2024, 1:15 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM30437f95dcbf: [identity] fix wallet account deletion bug
Summary

in D12335 i missed that get_username_and_password_file returns an error if the username attribute is missing, causing the whole RPC to fail. rather than modify that db method, i've decided to introduce a new one that just checks for the existence of OPAQUE registration data in a user item. the method returns an error if the lookup fails or if the user doesn't exist.

Resolves https://linear.app/comm/issue/ENG-8474/wallet-account-deletion-not-working

Test Plan

tested on staging -- confirmed that wallet account deletion now works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 20 2024, 11:13 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 11:13 AM
varun published this revision for review.Jun 20 2024, 11:13 AM
Harbormaster completed remote builds in B29837: Diff 41572.Jun 20 2024, 11:30 AM
varun added a reviewer: bartek.Jun 20 2024, 1:11 PM
will accepted this revision.Jun 20 2024, 1:18 PM
varun added inline comments.Jun 20 2024, 9:08 PM
services/identity/src/database.rs
742 ↗(On Diff #41572)

i'll remove the extra backtick

varun added a child revision: D12544: [identity] fix reserved username workflow for wallet users.Jun 21 2024, 4:36 PM
bartek accepted this revision.Jun 21 2024, 10:41 PM
bartek added inline comments.
services/identity/src/database.rs
749–751 ↗(On Diff #41572)

any log what failed?

752–755 ↗(On Diff #41572)

Nit. No even need to mutate

This revision is now accepted and ready to land.Jun 21 2024, 10:41 PM
Closed by commit rCOMM30437f95dcbf: [identity] fix wallet account deletion bug (authored by varun). · Explain WhyJun 24 2024, 10:29 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM30437f95dcbf: [identity] fix wallet account deletion bug.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
13 lines
grpc_services/
6 lines

Diff 41651

View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...