if a user cancels the request to sign the SIWE message from their wallet, we get an uncaught exception. wrap the call to signMessage with a try-catch to fix this bug
Depends on D12548
Details
Details
canceled SIWE message signing from my wallet and didn't get an uncaught exception
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Can any other errors be thrown by signer.signMessage? Should we still throw them if so?
Comment Actions
I think we have to swallow the error here no matter what. If we re-throw, we get an uncaught exception error. Regardless of the error, the user will have to click the sign in button again to be prompted to sign a new message from their wallet