Page MenuHomePhabricator
Differential D12515

[identity] fix wallet account deletion bug
ClosedPublic
Actions

Authored by varun on Thu, Jun 20, 11:13 AM.
Tags
None
Referenced Files
F2144529: D12515.diff
Sat, Jun 29, 8:20 PM
F2143858: D12515.id41652.diff
Sat, Jun 29, 6:31 PM
Unknown Object (File)
Fri, Jun 28, 3:22 PM
Unknown Object (File)
Thu, Jun 27, 11:07 AM
Unknown Object (File)
Wed, Jun 26, 9:14 PM
Unknown Object (File)
Mon, Jun 24, 2:56 PM
Unknown Object (File)
Sun, Jun 23, 10:08 AM
Unknown Object (File)
Thu, Jun 20, 4:57 PM
View All 10 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM30437f95dcbf: [identity] fix wallet account deletion bug
Summary

in D12335 i missed that get_username_and_password_file returns an error if the username attribute is missing, causing the whole RPC to fail. rather than modify that db method, i've decided to introduce a new one that just checks for the existence of OPAQUE registration data in a user item. the method returns an error if the lookup fails or if the user doesn't exist.

Resolves https://linear.app/comm/issue/ENG-8474/wallet-account-deletion-not-working

Test Plan

tested on staging -- confirmed that wallet account deletion now works

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Thu, Jun 20, 11:13 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 20, 11:13 AM
varun published this revision for review.Thu, Jun 20, 11:13 AM
Harbormaster completed remote builds in B29837: Diff 41572.Thu, Jun 20, 11:30 AM
varun added a reviewer: bartek.Thu, Jun 20, 1:11 PM
will accepted this revision.Thu, Jun 20, 1:18 PM
varun added inline comments.Thu, Jun 20, 9:08 PM
services/identity/src/database.rs
742

i'll remove the extra backtick

varun added a child revision: D12544: [identity] fix reserved username workflow for wallet users.Fri, Jun 21, 4:36 PM
bartek accepted this revision.Fri, Jun 21, 10:41 PM
bartek added inline comments.
services/identity/src/database.rs
749–751

any log what failed?

752–755

Nit. No even need to mutate

This revision is now accepted and ready to land.Fri, Jun 21, 10:41 PM
Closed by commit rCOMM30437f95dcbf: [identity] fix wallet account deletion bug (authored by varun). · Explain WhyMon, Jun 24, 10:29 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM30437f95dcbf: [identity] fix wallet account deletion bug.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
grpc_services/
6 lines

Diff 41572

View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...