[keyserver][lib] Move clientResponseInputValidator to lib
ClosedPublic
Actions

Authored by ashoat on Jun 8 2024, 3:34 PM.

Details

Reviewers

tomek

Commits

rCOMM26e50bb0dad2: [keyserver][lib] Move clientResponseInputValidator to lib

Summary

Initially, I thought I needed to move these to lib because I was about to introduce a new endpoint that took ClientResponses as input.

I ended up removing ClientResponses from the input, so this diff isn't really necessary.

That said, I feel like it's probably "good practice" in our codebase to move all validators to lib, so I decided to put this diff up. If reviewers disagree, I'm open to abandoning it.

Note that this also required moving some validators for reports.

Depends on D12360

Test Plan

This is a pure move diff. Careful code inspection and Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 8 2024, 3:34 PM

ashoat added a child revision: D12362: [keyserver][lib] Move sessionStateValidator to lib.

Harbormaster completed remote builds in B29551: Diff 41138.Jun 8 2024, 3:51 PM

ashoat requested review of this revision.Jun 8 2024, 3:51 PM

tomek accepted this revision.Jun 10 2024, 3:47 AM

tomek added inline comments.

lib/types/request-types.js
21–26 ↗	(On Diff #41138)	In most of the places we don't use `shape` suffixes for types and validators, so maybe we can remove them. But it's up to you.

This revision is now accepted and ready to land.Jun 10 2024, 3:47 AM

ashoat added inline comments.Jun 10 2024, 5:47 AM

lib/types/request-types.js
21–26 ↗	(On Diff #41138)	I think the "shape" suffix is here because the type is not used for a response/result/payload, but rather is a shape that gets combined with some `type` field before being used for a response/result/payload