[lib] Rename failuresAfterPolicyAcknowledgment to initFailureCountAfterPolicyAcknowledgment
ClosedPublic
Actions

Authored by ashoat on Jun 8 2024, 3:45 PM.

Tags

None

Referenced Files

	F3492370: D12368.id41191.diff
	Wed, Dec 18, 11:25 PM

	F3491915: D12368.diff
	Wed, Dec 18, 9:16 PM

	Unknown Object (File)
	Sun, Dec 15, 3:05 AM

	Unknown Object (File)
	Sun, Dec 15, 3:05 AM

	Unknown Object (File)
	Sun, Dec 15, 3:05 AM

	Unknown Object (File)
	Sun, Dec 15, 3:04 AM

	Unknown Object (File)
	Sun, Dec 15, 3:03 AM

	Unknown Object (File)
	Fri, Dec 6, 9:52 AM

View All 67 Files

Subscribers

None

Details

Reviewers

tomek

Commits

rCOMM982273ca5181: [lib] Rename failuresAfterPolicyAcknowledgment to…

Summary

I think it's good to clarify what kind of failure it is (an initialization failure).

Depends on D12367

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 8 2024, 3:45 PM

ashoat added a child revision: D12369: [lib][native][web] Recover from socket crash loop using fetchPendingUpdates.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 8 2024, 4:03 PM

Harbormaster failed remote builds in B29558: Diff 41145!

Rebase

Harbormaster completed remote builds in B29561: Diff 41148.Jun 8 2024, 6:49 PM

ashoat requested review of this revision.Jun 8 2024, 6:49 PM

tomek accepted this revision.Jun 10 2024, 6:44 AM

This revision is now accepted and ready to land.Jun 10 2024, 6:44 AM

Closed by commit rCOMM982273ca5181: [lib] Rename failuresAfterPolicyAcknowledgment to… (authored by ashoat). · Explain WhyJun 10 2024, 2:03 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM982273ca5181: [lib] Rename failuresAfterPolicyAcknowledgment to….

Revision Contents
Changeset List

Path

Size

lib/

socket/

socket.react.js

12 lines

Diff 41191

View Options

lib/socket/socket.react.js

[lib] Rename failuresAfterPolicyAcknowledgment to initFailureCountAfterPolicyAcknowledgmentClosedPublicActions