Paths

Table of Contentst

Differential D12541

[native] handle loading state in TagFarcasterChannelByName
ClosedPublic
Actions

Authored by ginsu on Jun 21 2024, 11:37 AM.

Tags

None

Referenced Files

	F3280038: D12541.diff
	Sat, Nov 16, 9:01 AM

	Unknown Object (File)
	Sun, Nov 3, 4:56 AM

	Unknown Object (File)
	Sun, Nov 3, 4:56 AM

	Unknown Object (File)
	Sun, Nov 3, 4:56 AM

	Unknown Object (File)
	Sun, Nov 3, 4:56 AM

	Unknown Object (File)
	Sun, Nov 3, 4:56 AM

	Unknown Object (File)
	Sun, Nov 3, 4:56 AM

	Unknown Object (File)
	Oct 12 2024, 2:18 PM

View All 59 Files

Subscribers

Details

Reviewers

inka
kamil

Commits

rCOMMeb88aad04d8d: [native] handle loading state in TagFarcasterChannelByName

Summary

As I am working on bringing the channel tagging UI to web, I noticed that I did not properly handle loading states in the TagFarcasterChannelByName screen. We can use the newly introduced useCreateFarcasterChannelTag hook to both fix this omission + simply this component

Test Plan

Confirmed that there is a loading state when attempting to tag a farcaster channel by name

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 21 2024, 11:37 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2024, 11:37 AM

Harbormaster completed remote builds in B29878: Diff 41621.Jun 21 2024, 11:53 AM

ginsu requested review of this revision.Jun 21 2024, 11:53 AM

update

ginsu edited the summary of this revision. (Show Details)Jun 21 2024, 12:29 PM

ginsu added reviewers: inka, kamil.

Harbormaster completed remote builds in B29879: Diff 41622.Jun 21 2024, 12:56 PM

ginsu added a child revision: D12542: [native] fix error handling in TagFarcasterChannelByName.Jun 21 2024, 1:31 PM

inka accepted this revision.Jun 24 2024, 12:10 AM

This revision is now accepted and ready to land.Jun 24 2024, 12:10 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 24 2024, 10:25 AM

Closed by commit rCOMMeb88aad04d8d: [native] handle loading state in TagFarcasterChannelByName (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMeb88aad04d8d: [native] handle loading state in TagFarcasterChannelByName.

Harbormaster completed remote builds in B29898: Diff 41645.Jun 24 2024, 10:39 AM

Revision Contents
Changeset List

Path

Size

native/

community-settings/

tag-farcaster-channel/

tag-farcaster-channel-by-name.react.js

48 lines

Diff 41622

native/community-settings/tag-farcaster-channel/tag-farcaster-channel-by-name.react.js

Loading...