Page MenuHomePhabricator
Differential D12644

[native] introduce new vector assets for new thread notification settings experience
ClosedPublic
Actions

Authored by ginsu on Jul 2 2024, 6:43 PM.
Tags
None
Referenced Files
F2897602: D12644.diff
Fri, Oct 4, 11:53 PM
Unknown Object (File)
Wed, Sep 25, 9:02 PM
Unknown Object (File)
Wed, Sep 25, 9:01 PM
Unknown Object (File)
Mon, Sep 9, 4:45 AM
Unknown Object (File)
Thu, Sep 5, 6:41 PM
Unknown Object (File)
Thu, Sep 5, 6:40 PM
Unknown Object (File)
Thu, Sep 5, 6:39 PM
Unknown Object (File)
Sep 4 2024, 5:06 AM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMd3ab2492c51c: [native] introduce new vector assets for new thread notification settings…
Summary

We need three new assets for the new thread notification settings. This diff introduces them.

Copied the svg code from the web assets and used the this tool (recommended by SWM) to convert the svg code to react-native-svg:

https://react-svgr.com/playground/

Test Plan

Confirmed that the new vector assets looked good

Screenshot 2024-07-02 at 9.46.36 PM.png (1×1 px, 760 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 2 2024, 6:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 2 2024, 6:43 PM
ginsu edited the summary of this revision. (Show Details)Jul 2 2024, 6:46 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu attached a referenced file: F2172061: Screenshot 2024-07-02 at 9.46.36 PM.png. (Show Details)
Harbormaster completed remote builds in B30071: Diff 41922.Jul 2 2024, 7:00 PM
ginsu requested review of this revision.Jul 2 2024, 7:00 PM
ashoat accepted this revision.Jul 2 2024, 7:14 PM
This revision is now accepted and ready to land.Jul 2 2024, 7:14 PM
ginsu edited the summary of this revision. (Show Details)Jul 2 2024, 7:16 PM
ginsu added a parent revision: D12643: [native] introduce type prop to EnumSettingsOption component.
ginsu added a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.Jul 3 2024, 1:04 AM
ginsu edited the summary of this revision. (Show Details)Jul 3 2024, 3:04 PM
ginsu removed a parent revision: D12643: [native] introduce type prop to EnumSettingsOption component.
ginsu removed a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.

Removing this diff from the stack so I can land as is (locally rebased + confirmed that this is safe)

ginsu updated this revision to Diff 41963.Jul 3 2024, 3:10 PM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Jul 3 2024, 3:13 PM
Closed by commit rCOMMd3ab2492c51c: [native] introduce new vector assets for new thread notification settings… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd3ab2492c51c: [native] introduce new vector assets for new thread notification settings….
Harbormaster completed remote builds in B30099: Diff 41963.Jul 3 2024, 3:41 PM

Revision Contents
Changeset List

Diff 41922

View Options

native/vectors/all-notifs-illustration.react.js

Loading...
View Options

native/vectors/badge-notifs-illustration.react.js

Loading...
View Options

native/vectors/muted-notifs-illustration.react.js

Loading...