[native] introduce type prop to EnumSettingsOption component
ClosedPublic
Actions

Authored by ginsu on Tue, Jul 2, 6:32 PM.

Details

Reviewers

ashoat
inka

Commits

rCOMM8ec15fd60aa1: [native] introduce type prop to EnumSettingsOption component

Summary

Our EnumSettingsOption component on native only supports checkbox type input. For this new thread notif settings experience we need to have a radio type input

Depends on D12642

Test Plan

Confirmed that there were no regressions with where we render EnumSettingsOption in the create roles and community creation screens

Also confirmed that the radio input looked like this:

Screenshot 2024-07-02 at 9.41.27 PM.png (1×1 px, 759 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Tue, Jul 2, 6:32 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Jul 2, 6:32 PM

update

ginsu edited the summary of this revision. (Show Details)Tue, Jul 2, 6:41 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12642: [native] introduce nav logic for ThreadSettingsNotifications.

ginsu edited the test plan for this revision. (Show Details)

Harbormaster failed remote builds in B30068: Diff 41919!Tue, Jul 2, 6:45 PM

Harbormaster completed remote builds in B30070: Diff 41921.Tue, Jul 2, 6:55 PM

ginsu requested review of this revision.Tue, Jul 2, 6:55 PM

ginsu added a child revision: D12644: [native] introduce new vector assets for new thread notification settings experience.Tue, Jul 2, 7:16 PM

Can we try to space it out more? I'd like more margin between option, and to balance the space on the right side. We can try to work through it together tomorrow in person if you're in the office
If 2/3 of the usages are going to checkbox instead of radio, should we default to checkbox?

This revision now requires changes to proceed.Tue, Jul 2, 7:19 PM

ginsu mentioned this in D12647: [native] introduce barebones UI for ThreadSettingsNotifications.Wed, Jul 3, 1:11 AM

ginsu removed a child revision: D12644: [native] introduce new vector assets for new thread notification settings experience.Wed, Jul 3, 3:04 PM

ginsu added a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.Wed, Jul 3, 5:39 PM

Can we try to space it out more? I'd like more margin between option, and to balance the space on the right side. We can try to work through it together tomorrow in person if you're in the office

D12654 updates the UI further in this stack