Details

Reviewers

ashoat
inka

Commits

rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications

Summary

For the new thread notif settings we decided that we want this user experience to have it's own page. This diff introduces the nave logic needed for this

Linear task: https://linear.app/comm/issue/ENG-7776/improve-thread-notifications-settings-user-experience

Test Plan

Confirmed that I can navigate to this screen

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Tue, Jul 2, 6:06 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Jul 2, 6:06 PM

update

ginsu added inline comments.Tue, Jul 2, 6:12 PM

native/chat/chat.react.js
335–337 ↗	(On Diff #41918)	Confirmed this is the same behavior with `web` nonsidebar: sidebar:

ginsu attached a referenced file: F2171721: Screenshot 2024-07-02 at 9.07.31 PM.png. (Show Details)Tue, Jul 2, 6:12 PM

ginsu attached a referenced file: F2171719: Screenshot 2024-07-02 at 9.07.21 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added reviewers: ashoat, inka.

Harbormaster failed remote builds in B30066: Diff 41917!Tue, Jul 2, 6:19 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jul 2, 6:22 PM

Harbormaster failed remote builds in B30067: Diff 41918!

update

ginsu added inline comments.Tue, Jul 2, 6:37 PM

native/chat/chat.react.js
335–337 ↗	(On Diff #41920)	Confirmed this is the same behavior with `web` nonsidebar: sidebar:

ginsu attached a referenced file: F2171946: Screenshot 2024-07-02 at 9.07.31 PM.png. (Show Details)Tue, Jul 2, 6:37 PM

ginsu attached a referenced file: F2171943: Screenshot 2024-07-02 at 9.07.21 PM.png. (Show Details)

ginsu added a child revision: D12643: [native] introduce type prop to EnumSettingsOption component.Tue, Jul 2, 6:41 PM

Harbormaster completed remote builds in B30069: Diff 41920.Tue, Jul 2, 6:52 PM

ginsu requested review of this revision.Tue, Jul 2, 6:52 PM

ashoat accepted this revision.Tue, Jul 2, 7:14 PM

This revision is now accepted and ready to land.Tue, Jul 2, 7:14 PM

ginsu added a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.Wed, Jul 3, 5:37 PM

ginsu removed a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.

rebase before landing

Harbormaster completed remote builds in B30153: Diff 42044.Thu, Jul 4, 11:03 AM

Closed by commit rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications (authored by ginsu). · Explain WhyThu, Jul 4, 11:21 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications.

[native] introduce nav logic for ThreadSettingsNotifications
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42066

native/chat/chat.react.js

native/chat/settings/thread-settings-notifications.react.js

native/navigation/route-names.js

[native] introduce nav logic for ThreadSettingsNotificationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42066

native/chat/chat.react.js

native/chat/settings/thread-settings-notifications.react.js

native/navigation/route-names.js

[native] introduce nav logic for ThreadSettingsNotifications
ClosedPublic
Actions

Revision Contents
Changeset List