Paths

Table of Contentst

Differential D12654

[native] update EnumSettingsOption UI
ClosedPublic
Actions

Authored by ginsu on Wed, Jul 3, 5:41 PM.

Tags

None

Referenced Files

	F2189691: Screen Recording 2024-07-04 at 1.56.02 PM.mov
	Thu, Jul 4, 10:57 AM

	Unknown Object (File)
	Wed, Jul 3, 11:17 PM

	Unknown Object (File)
	Wed, Jul 3, 11:17 PM

	Unknown Object (File)
	Wed, Jul 3, 11:17 PM

	Unknown Object (File)
	Wed, Jul 3, 11:14 PM

	F2181848: Screen Recording 2024-07-03 at 9.21.47 PM.mov
	Wed, Jul 3, 6:22 PM

	F2181699: Screen Recording 2024-07-03 at 8.50.31 PM.mov
	Wed, Jul 3, 6:22 PM

	F2181635: Screen Recording 2024-07-03 at 8.49.14 PM.mov
	Wed, Jul 3, 6:22 PM

View All 10 Files

Subscribers

Details

Reviewers

ashoat
inka

Commits

rCOMM35a34d3e2ca4: [native] update EnumSettingsOption UI

Summary

This diff updates the EnumSettingsOption UI to better match the web version of EnumSettingsOption. One big notable change with EnumSettingsOption is that the entire surface is now a touchable rather than just the input. This also matches the behavior we have on web.

Depends on D12653

Test Plan

Please see the demo videos below of all the places we use this component

Create community:
Before:

After:

Create Role:

Before:

After:

Thread notifs settings:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, Jul 3, 5:41 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 5:41 PM

update

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jul 3, 5:59 PM

Harbormaster failed remote builds in B30104: Diff 41975!

Harbormaster completed remote builds in B30103: Diff 41974.

ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 6:22 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12653: [native] introduce disabled prop for EnumSettingsOption.

ginsu attached a referenced file: F2181848: Screen Recording 2024-07-03 at 9.21.47 PM.mov. (Show Details)

ginsu attached a referenced file: F2181699: Screen Recording 2024-07-03 at 8.50.31 PM.mov. (Show Details)

ginsu attached a referenced file: F2181635: Screen Recording 2024-07-03 at 8.49.14 PM.mov. (Show Details)

ginsu attached a referenced file: F2181694: Screen Recording 2024-07-03 at 8.55.11 PM.mov. (Show Details)

ginsu attached a referenced file: F2181636: Screen Recording 2024-07-03 at 8.48.22 PM.mov. (Show Details)

ginsu mentioned this in D12643: [native] introduce type prop to EnumSettingsOption component.Wed, Jul 3, 6:27 PM

Harbormaster completed remote builds in B30104: Diff 41975.Wed, Jul 3, 6:28 PM

ginsu requested review of this revision.Wed, Jul 3, 6:28 PM

ashoat accepted this revision.Wed, Jul 3, 8:19 PM

ashoat added inline comments.

native/roles/create-roles-screen.react.js
312–313 ↗	(On Diff #41975)	Should we make similar changes for the community creation flow? It looks a bit scrunched up in the video

This revision is now accepted and ready to land.Wed, Jul 3, 8:19 PM

ginsu added a child revision: D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.Wed, Jul 3, 8:46 PM

address comments + rebase before landing

ginsu edited the test plan for this revision. (Show Details)Thu, Jul 4, 10:57 AM

ginsu attached a referenced file: F2189691: Screen Recording 2024-07-04 at 1.56.02 PM.mov. (Show Details)

Harbormaster completed remote builds in B30157: Diff 42048.Thu, Jul 4, 11:15 AM

Closed by commit rCOMM35a34d3e2ca4: [native] update EnumSettingsOption UI (authored by ginsu). · Explain WhyThu, Jul 4, 11:21 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM35a34d3e2ca4: [native] update EnumSettingsOption UI.

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-configuration.react.js

22 lines

components/

enum-settings-option.react.js

60 lines

roles/

create-roles-screen.react.js

3 lines

Diff 42070

native/community-creation/community-configuration.react.js

Loading...

native/components/enum-settings-option.react.js

Loading...

native/roles/create-roles-screen.react.js

Loading...