Paths

Table of Contentst

[native] deprecate ThreadSettingsHomeNotifs
ClosedPublic
Actions

Authored by ginsu on Thu, Jul 4, 12:27 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs

Summary

We have some logic that is no longer used. This diff deprecates all the unused logic

Depends on D12665

Test Plan

flow + confirmed everything works as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Thu, Jul 4, 12:27 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jul 4, 12:27 AM

ginsu edited the summary of this revision. (Show Details)Thu, Jul 4, 12:27 AM

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.

Harbormaster completed remote builds in B30131: Diff 42002.Thu, Jul 4, 12:43 AM

ginsu requested review of this revision.Thu, Jul 4, 12:43 AM

ashoat accepted this revision.Thu, Jul 4, 6:40 AM

This revision is now accepted and ready to land.Thu, Jul 4, 6:40 AM

rebae before landing

This revision was landed with ongoing or failed builds.Thu, Jul 4, 11:21 AM

Closed by commit rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs.

Harbormaster completed remote builds in B30168: Diff 42065.Thu, Jul 4, 12:12 PM

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings-home-notifs.react.js

thread-settings.react.js

15 lines

Diff 42078

View Options

native/chat/settings/thread-settings-home-notifs.react.js