Tags

None

Referenced Files

	F3357912: D12666.diff
	Sun, Nov 24, 2:28 AM

	Unknown Object (File)
	Sun, Nov 10, 11:19 PM

	Unknown Object (File)
	Sun, Nov 10, 10:12 PM

	Unknown Object (File)
	Sun, Nov 10, 1:52 PM

	Unknown Object (File)
	Fri, Nov 8, 10:39 PM

	Unknown Object (File)
	Fri, Nov 8, 7:14 AM

	Unknown Object (File)
	Oct 11 2024, 5:26 AM

	Unknown Object (File)
	Oct 11 2024, 5:26 AM

View All 54 Files

Subscribers

ashoat

tomek

Details

Reviewers

ashoat
inka

Commits

rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs

Summary

We have some logic that is no longer used. This diff deprecates all the unused logic

Depends on D12665

Test Plan

flow + confirmed everything works as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 4 2024, 12:27 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 4 2024, 12:27 AM

ginsu edited the summary of this revision. (Show Details)Jul 4 2024, 12:27 AM

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.

Harbormaster completed remote builds in B30131: Diff 42002.Jul 4 2024, 12:43 AM

ginsu requested review of this revision.Jul 4 2024, 12:43 AM

ashoat accepted this revision.Jul 4 2024, 6:40 AM

This revision is now accepted and ready to land.Jul 4 2024, 6:40 AM

rebae before landing

This revision was landed with ongoing or failed builds.Jul 4 2024, 11:21 AM

Closed by commit rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM686c0d8f3f29: [native] deprecate ThreadSettingsHomeNotifs.

Harbormaster completed remote builds in B30168: Diff 42065.Jul 4 2024, 12:12 PM

[native] deprecate ThreadSettingsHomeNotifs
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42078

native/chat/settings/thread-settings-home-notifs.react.js

native/chat/settings/thread-settings.react.js

[native] deprecate ThreadSettingsHomeNotifsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42078

native/chat/settings/thread-settings-home-notifs.react.js

native/chat/settings/thread-settings.react.js

[native] deprecate ThreadSettingsHomeNotifs
ClosedPublic
Actions

Revision Contents
Changeset List