In our thread notif settings we display some notice text + disable the background option if the thread is a sidebar
Depends on D12648
Details
Details
Summary
Test Plan
Please see the screenshot below
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 10:02 PM2024-07-03 22:02:09 (UTC-7)
ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 10:07 PM2024-07-03 22:07:19 (UTC-7)
ginsu added a parent revision: D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.
ginsu removed a parent revision: D12661: [lib/native/web] factor out remaining shared logic + copy for thread notification settings.
Harbormaster completed remote builds in B30125: Diff 41996.Wed, Jul 3, 10:18 PM2024-07-03 22:18:32 (UTC-7)
This revision is now accepted and ready to land.Thu, Jul 4, 6:28 AM2024-07-04 06:28:47 (UTC-7)
This revision was landed with ongoing or failed builds.Thu, Jul 4, 11:21 AM2024-07-04 11:21:28 (UTC-7)
Closed by commit rCOMM0e0eeebb12fa: [native] introduce thread notif settings notice text (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B30161: Diff 42053.Thu, Jul 4, 11:35 AM2024-07-04 11:35:38 (UTC-7)
Harbormaster completed remote builds in B30162: Diff 42054.Thu, Jul 4, 11:41 AM2024-07-04 11:41:21 (UTC-7)