Page MenuHomePhabricator
Differential D12653

[native] introduce disabled prop for EnumSettingsOption
ClosedPublic
Actions

Authored by ginsu on Wed, Jul 3, 5:31 PM.
Tags
None
Referenced Files
F2207385: D12653.diff
Sun, Jul 7, 7:35 AM
Unknown Object (File)
Wed, Jul 3, 11:17 PM
Unknown Object (File)
Wed, Jul 3, 11:17 PM
Unknown Object (File)
Wed, Jul 3, 11:14 PM
F2181368: Screenshot 2024-07-03 at 8.34.47 PM.png
Wed, Jul 3, 5:35 PM
F2181344: Screenshot 2024-07-03 at 8.32.46 PM.png
Wed, Jul 3, 5:35 PM
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMa9358077a210: [native] introduce disabled prop for EnumSettingsOption
Summary

For the new thread notifications settings we will need to be able to disable the input. This diff introduces the disabled prop to EnumSettingsOption in anticipation of this

example of disabled input:

Screenshot 2024-07-03 at 8.32.46 PM.png (2×3 px, 945 KB)

Depends on D12645

Test Plan

Please see screenshots below

Screenshot 2024-07-03 at 8.34.47 PM.png (1×944 px, 588 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, Jul 3, 5:31 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 5:31 PM
ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 5:35 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu added a parent revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
ginsu attached a referenced file: F2181368: Screenshot 2024-07-03 at 8.34.47 PM.png. (Show Details)
ginsu attached a referenced file: F2181344: Screenshot 2024-07-03 at 8.32.46 PM.png. (Show Details)
Harbormaster completed remote builds in B30102: Diff 41973.Wed, Jul 3, 5:47 PM
ginsu requested review of this revision.Wed, Jul 3, 5:47 PM
ginsu added a child revision: D12654: [native] update EnumSettingsOption UI.Wed, Jul 3, 6:22 PM
ashoat accepted this revision.Wed, Jul 3, 8:16 PM
This revision is now accepted and ready to land.Wed, Jul 3, 8:16 PM
ginsu updated this revision to Diff 42047.Thu, Jul 4, 10:49 AM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B30156: Diff 42047.Thu, Jul 4, 11:08 AM
Closed by commit rCOMMa9358077a210: [native] introduce disabled prop for EnumSettingsOption (authored by ginsu). · Explain WhyThu, Jul 4, 11:21 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa9358077a210: [native] introduce disabled prop for EnumSettingsOption.

Revision Contents
Changeset List

PathSize
native/
components/
19 lines

Diff 42069

View Options

native/components/enum-settings-option.react.js

Loading...